http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DDC-875 Doctrine 2 - ORM <p>When merging some cascade merge object-graphs, the same entity in a ManyToMany association can be put into a collection twice during doMerge.</p> <p>The attached patch should stop this from happening.</p> DDC-875

Merge can sometimes add the same entity twice into a collection

Bug Major Closed Cannot Reproduce All Roman S. Borschel Dave Keen Thu, 11 Nov 2010 08:50:47 +0000 Sun, 11 Mar 2012 20:46:45 +0000 Sun, 11 Mar 2012 20:46:45 +0000 2.0-BETA4 ORM 1 2 <p>which conditions lead to this problem? I want to write a test for it</p> <p>not doint the unwrap() but add() directly was a bugfix for one of your other issues .Why is unwrap in here again?</p> <p>Oops - that was a mistake. I have attached multipleaddmerge2.diff which no longer uses unwrap to add the element.</p> <p>That is exactly the same code in the patch, the lines are just formatted differently.</p> <p>Sorry, I am still getting the hang of git and diff and maybe what I put in there isn't what I meant to. I have now pushed the code to the <a href="http://www.doctrine-project.org/jira/browse/DDC-875" title="Merge can sometimes add the same entity twice into a collection"><del>DDC-875</del></a> branch on my ccapndave/doctrine2 fork on GitHub, hopefully this works better.</p> <p>As far as I can tell I am using unwrap() in order to check whether the element already exists in the array, but then calling <del>&gt;add() directly on the PersistentCollection rather than the ArrayCollection, triggering $this</del>&gt;changed().</p> <p>It seems even this issue is caused by multiple calls to persist. I cannot reproduce this with just a single bidirectional cascade merge.</p> <p>We cannot reproduce this error and haven't had similar complaints ever-since. Feel free to open a new issue with a failing testcase.</p>