<!-- 
RSS generated by JIRA (5.2.7#850-sha1:b2af0c8dc8537b36121c6a579fabbdf79fc919e5) at Sun May 19 07:50:25 UTC 2013

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary add field=key&field=summary to the URL of your request.
For example:
http://www.doctrine-project.org/jira/si/jira.issueviews:issue-xml/DDC-536/DDC-536.xml?field=key&field=summary
-->
<rss version="0.92" >
<channel>
    <title>Doctrine Project</title>
    <link>http://www.doctrine-project.org/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>5.2.7</version>
        <build-number>850</build-number>
        <build-date>21-02-2013</build-date>
    </build-info>

<item>
            <title>[DDC-536] Remove the _ prefix from private and protected members</title>
                <link>http://www.doctrine-project.org/jira/browse/DDC-536</link>
                <project id="10032" key="DDC">Doctrine 2 - ORM</project>
                        <description>&lt;p&gt;The reasoning is simple: The prefix &quot;_&quot; is usually either used for easier distinction of instance variables from other, i.e. local variables, instead of always using &quot;this.&quot; (often seen in C#), or it is used to signal that a member is not meant to be accessed from outside of the class when the language does not have visibility modifiers (PHP4).&lt;/p&gt;

&lt;p&gt;Since you always have to use &quot;$this-&amp;gt;&quot; in PHP5+ when accessing instance members and there are visibility modifiers, the &quot;_&quot; is largely superfluous and just makes the verbose OO code even more verbose.&lt;/p&gt;

&lt;p&gt;Maybe the following find/replace steps will do the job almost completely:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-quote&quot;&gt;&quot;&lt;span class=&quot;code-keyword&quot;&gt;private&lt;/span&gt; $_&quot;&lt;/span&gt; =&amp;gt; &lt;span class=&quot;code-quote&quot;&gt;&quot;&lt;span class=&quot;code-keyword&quot;&gt;private&lt;/span&gt; $&quot;&lt;/span&gt;
&lt;span class=&quot;code-quote&quot;&gt;&quot;&lt;span class=&quot;code-keyword&quot;&gt;protected&lt;/span&gt; $_&quot;&lt;/span&gt; =&amp;gt; &lt;span class=&quot;code-quote&quot;&gt;&quot;&lt;span class=&quot;code-keyword&quot;&gt;protected&lt;/span&gt; $&quot;&lt;/span&gt;
&lt;span class=&quot;code-quote&quot;&gt;&quot;$&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;-&amp;gt;_&quot;&lt;/span&gt; =&amp;gt; &lt;span class=&quot;code-quote&quot;&gt;&quot;$&lt;span class=&quot;code-keyword&quot;&gt;this&lt;/span&gt;-&amp;gt;&quot;&lt;/span&gt;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
            <key id="11261">DDC-536</key>
            <summary>Remove the _ prefix from private and protected members</summary>
                <type id="3" iconUrl="http://www.doctrine-project.org/jira/images/icons/issuetypes/task.png">Task</type>
                                <priority id="3" iconUrl="http://www.doctrine-project.org/jira/images/icons/priorities/major.png">Major</priority>
                    <status id="1" iconUrl="http://www.doctrine-project.org/jira/images/icons/statuses/open.png">Open</status>
                    <resolution id="-1">Unresolved</resolution>
                    <security id="10000">All</security>
                        <assignee username="romanb">Roman S. Borschel</assignee>
                                <reporter username="romanb">Roman S. Borschel</reporter>
                        <labels>
                    </labels>
                <created>Fri, 23 Apr 2010 09:26:24 +0000</created>
                <updated>Fri, 19 Nov 2010 00:00:39 +0000</updated>
                                                    <fixVersion>2.0</fixVersion>
                                        <due></due>
                    <votes>1</votes>
                        <watches>3</watches>
                        <comments>
                    <comment id="12761" author="beberlei" created="Tue, 27 Apr 2010 05:50:39 +0000"  >&lt;p&gt;i just found a possible BC issue with this.&lt;/p&gt;

&lt;p&gt;EntityRepository is allowed to be extended by us, it has several variables that are underscore prefixed. How to proceed in this case?&lt;/p&gt;</comment>
                    <comment id="12762" author="romanb" created="Tue, 27 Apr 2010 05:56:06 +0000"  >&lt;p&gt;I know but its not really a problem I think. We should just decide whether we make them private in the first place and provide getters instead (which would have avoided this problem in the first place).&lt;/p&gt;</comment>
                    <comment id="12763" author="romanb" created="Tue, 27 Apr 2010 05:56:59 +0000"  >&lt;p&gt;Leaving the prefixes on the repository class only is also an option... but I dont think thats necessary.&lt;/p&gt;</comment>
                    <comment id="12764" author="beberlei" created="Tue, 27 Apr 2010 06:28:59 +0000"  >&lt;p&gt;can we commit getters for Beta 1 then? We could give everyone a period until Beta 2 to fix their code and then make the change.&lt;/p&gt;

&lt;p&gt;EntityRepository is the only class that is meant to be userland extendable to my knowledge, so this should be the only problem to adress&lt;/p&gt;</comment>
                    <comment id="12766" author="romanb" created="Tue, 27 Apr 2010 09:25:21 +0000"  >&lt;p&gt;Yes, you can add getters and commit right away if you want. Plus adding a note on the upgrade document that direct access of these properties is deprecated.&lt;/p&gt;</comment>
                    <comment id="12767" author="romanb" created="Tue, 27 Apr 2010 09:26:22 +0000"  >&lt;p&gt;Persisters will be also extensible some day in userland but they need more polish for that, I&apos;ve already started with it &lt;img class=&quot;emoticon&quot; src=&quot;http://www.doctrine-project.org/jira/images/icons/emoticons/smile.gif&quot; height=&quot;20&quot; width=&quot;20&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                    <comment id="14785" author="johnnypeck" created="Fri, 19 Nov 2010 00:00:39 +0000"  >&lt;p&gt;Is this still planned? Searching the code base finds this is not being implemented. It would be a good idea to implement the change sooner than later if it will be done at all.  Also, +1 for the change. It makes complete sense.&lt;/p&gt;</comment>
                </comments>
                    <attachments>
                </attachments>
            <subtasks>
        </subtasks>
        </item>
</channel>
</rss>