Doctrine Project http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 [DDC-2322] [GH-592] Added ability to specify INDEX BY when creating a QueryBuilder from a Repository http://www.doctrine-project.org/jira/browse/DDC-2322 Doctrine 2 - ORM <p>This issue is created automatically through a Github pull request on behalf of cmenning:</p> <p> Url: <a href="https://github.com/doctrine/doctrine2/pull/592" class="external-link">https://github.com/doctrine/doctrine2/pull/592</a></p> <p>Message:</p> <p>This is a handy shortcut when using indexed results.</p> DDC-2322 [GH-592] Added ability to specify INDEX BY when creating a QueryBuilder from a Repository Improvement Minor Resolved Invalid All Benjamin Eberlei Benjamin Eberlei Wed, 27 Feb 2013 19:14:58 +0000 Tue, 12 Mar 2013 19:45:17 +0000 Tue, 12 Mar 2013 18:44:24 +0000 2.2 2.3 Git Master ORM 0 3 <p>A related Github Pull-Request <span class="error">&#91;GH-592&#93;</span> was closed<br/> <a href="https://github.com/doctrine/doctrine2/pull/592" class="external-link">https://github.com/doctrine/doctrine2/pull/592</a></p> <p>I disagree with the reasoning behind closing this request. In DoctrineBundle, </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>getDoctrine()-&gt;getEntityManager()</pre> </div></div> <p> has been deprecated, which leaves you to use </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>getDoctrine()-&gt;getRepository($class)-&gt;createQueryBuilder();</pre> </div></div> <p>Adding <tt>-&gt;from()</tt> at that point is redundant since it's already been specified inside the createQueryBuilder() call. It seems wasteful to not allow a passthru of the $indexBy argument during the initial call when it's already supported by the from() called inside createQueryBuilder().</p> <p>The repository is already (probably) doing too much. A simpler approach with:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">$qb = $em-&gt;createQueryBuilder()-&gt;select('e')-&gt;from($repo-&gt;getClassName(), 'e', 'e.stuff') </pre> </div></div> <p>Is no big deal in my opinion.</p>