http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DDC-2237 Doctrine 2 - ORM <p>If I have a query with a IN statement with more tahn 1000 values I get an sql error.</p> <p>I've try IN with implode:<br/> select * from test where id IN(' . implode(',', $values) . ')<br/> and I've also try with executeQuery:<br/> select * from test where id IN(:test)<br/> executeQuery($sql, array($values), array(\Doctrine\DBAL\Connection::PARAM_INT_ARRAY))</p> DDC-2237

oracle IN statement with more than 1000 values

Bug Critical Open Unresolved All Benjamin Eberlei Marc Drolet Fri, 11 Jan 2013 16:34:25 +0000 Tue, 2 Apr 2013 12:30:05 +0000 2.2.2 ORM 0 2 <p>Here is the way I've implement the solution on my side: (for oracle)</p> <p>into Doctrine/DBAL/Statement.php, I've add this method:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /** * Binds a parameter value to the statement. * This is implemented <span class="code-keyword">this</span> way <span class="code-keyword">for</span> oracle only. Other drivers are redirected to bindValue method. * * The value will be bound with to the type provided (that required to be a table type). * * @param <span class="code-object">String</span> $name The name or position of the parameter. * @param Array $value The value of the parameter. * @param <span class="code-object">String</span> $type The name of the type to use to bind. * @<span class="code-keyword">return</span> <span class="code-object">boolean</span> TRUE on success, FALSE on failure. */ <span class="code-keyword">public</span> function bindList($name, Array $value, $type) { <span class="code-keyword">if</span> ('oracle' !== $<span class="code-keyword">this</span>-&gt;platform-&gt;getName()) { $<span class="code-keyword">this</span>-&gt;bindValue($name, $value, $type); } <span class="code-keyword">else</span> { <span class="code-keyword">return</span> $<span class="code-keyword">this</span>-&gt;stmt-&gt;bindList($name, $value, $type); } } </pre> </div></div> <p>into Doctrine/DBAL/Driver/Statement.php I've add:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /** * @TODO: docs */ function bindList($param, Array $values, $type); </pre> </div></div> <p>into Doctrine/DBAL/Driver/OCI8/OCI8Statement.php I've add this method:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /** * {@inheritdoc} */ <span class="code-keyword">public</span> function bindList($param, Array $value, $type) { <span class="code-keyword">if</span> (!($list = oci_new_collection($<span class="code-keyword">this</span>-&gt;_dbh, $type))) { <span class="code-comment">//<span class="code-keyword">throw</span> <span class="code-keyword">new</span> OCI8Exception::fromErrorInfo($<span class="code-keyword">this</span>-&gt;errorInfo()); </span> } foreach ($value as $entry) { $list-&gt;append($entry); } <span class="code-keyword">if</span> (!oci_bind_by_name($<span class="code-keyword">this</span>-&gt;_sth, $param, $list, -1, OCI_B_NTY)) { <span class="code-comment">//<span class="code-keyword">throw</span> <span class="code-keyword">new</span> OCI8Exception::fromErrorInfo($<span class="code-keyword">this</span>-&gt;errorInfo()); </span> } } </pre> </div></div> <p>// NOTE: we should probably add the bindList to all driver Statement object. </p> <p>into your code you can use it this way:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> $sql = " SELECT * FROM test WHERE id IN ( SELECT * FROM ( CAST (: p_ids AS list_int_type) ) ) "; $stmt = connection-&gt;prepare($sql); $stmt-&gt;bindList(': p_ids', $ids, 'list_int_type'); $stmt-&gt;execute(); $rs = $stmt-&gt;fetchAll(PDO::FETCH_ASSOC); </pre> </div></div> <p>NOTE:<br/> list_int_type need to be a valid oracle data type. You can create one with the name you want.<br/> example:<br/> you can have 2 type of accepted array of values: integer and string<br/> let's say we create one for string named: list_str_type and one for integer list_int_type</p> <p> create or replace type list_str_type as table of varchar2(4000);<br/> create or replace type list_int_type as table of number;</p> <p>Hey <a href="http://www.doctrine-project.org/jira/secure/ViewProfile.jspa?name=mdrolet" class="user-hover" rel="mdrolet">Marc Drolet</a></p> <p>thanks for the feedback and the solution, however i would like to have something generic that is working independent of the database driver. This code is very specific.</p> <p>Can you point me to some documentation why oci collection works with more than 1000 elements and how it works in PHP?</p> <p>Hi Benjamin,</p> <p>The limitation is not from the oci driver, it's an oracle limitation. There are a couple of possible solution/implementation that can be done but the one I've provide is the one that perform better for the test I've done and from what I can found over the blogs I've read.</p> <p>I can't find the exact documentation of oracle. oracle doc is so poor. <br/> Here is the best description link I can provide that describe some possible implementation.<br/> <a href="http://vsadilovskiy.wordpress.com/substituting-a-collection-for-in-list-performance-study/" class="external-link">http://vsadilovskiy.wordpress.com/substituting-a-collection-for-in-list-performance-study/</a></p> <p>I don't know if there is similar limitation with other database. With the implementation I've provided, It will be possible to implement the proper solution depending on the database limitation you face otherwise it will execute the generic IN. What's bad, we need to create the type into the database.</p> <p>NOTE: In my case, I can not perform a sub-query, I get the my collection from a web service call.</p>