http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DDC-1919 Doctrine 2 - ORM <p>I have submitted a PR here, fixing part of this issue: <a href="https://github.com/doctrine/dbal/pull/166" class="external-link">https://github.com/doctrine/dbal/pull/166</a></p> <p>However, it fails when UPDATE or INSERT is used. I'm using a very simple, and common, entity name: Group. Doctrine is failing to escape this in various situations, causing queries to fail in MySQL due to reserved keywords.</p> MySQL DDC-1919

Doctrine fails to escape entity with reserved name in various situations

Bug Major Closed Invalid All Benjamin Eberlei Klaus Silveira Tue, 10 Jul 2012 21:34:08 +0000 Thu, 19 Jul 2012 18:27:21 +0000 Wed, 11 Jul 2012 19:28:24 +0000 2.2 2.3 Git Master 0 3 <p>Can you try using the quoting strategy in master? By defining an '@Table(name="`Group`")' on your entity you should be able to fix this issue by yourself... Anyway, this is only available in latest master.<br/> Please give it a try and let us know.</p> <p>That hack, of course, fixes the problem. However, Doctrine is failing to escape entities with reserved keywords in various different situations and this should be a major problem, specially since there are many keywords that are common table names. Having to change the table name or escape the table name manually is not the best solution.</p> <p>I have look through the code but could not find out why getQuotedTableName() is failing to quote the table name "Group". I fixed the other problem, involving schema creation, but this one i couldn't fix. That's why i'm opening the issue, hoping someone with more experience in the ORM codebase manages to fix it.</p> <p><a href="http://www.doctrine-project.org/jira/secure/ViewProfile.jspa?name=klaussilveira" class="user-hover" rel="klaussilveira">Klaus Silveira</a>, doctrine won't quote (at least with the default strategy) a table called "Group". The default strategy will look for the sorrounding "`" ("`Group`").<br/> Is it still failing to quote something in latest master? Can you write a simple example of a failure you are getting?</p> <p>The failure is caused when querying anything related to an entity wich it's name is a reserved keyword, for example, an entity called "Group". I expected Doctrine to quote such table names. </p> <p><a href="http://www.doctrine-project.org/jira/secure/ViewProfile.jspa?name=klaussilveira" class="user-hover" rel="klaussilveira">Klaus Silveira</a> did you put an @Table(name="`Group`") in it?</p> <p>Please note that </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <div class="error"><span class="error">Unable to find source-code formatter for language: php.</span> Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml</div><pre>@Table(name=<span class="code-quote">"Group"</span>)</pre> </div></div> <p> and </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <div class="error"><span class="error">Unable to find source-code formatter for language: php.</span> Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml</div><pre>@Table(name=<span class="code-quote">"`Group`"</span>)</pre> </div></div> <p> are quite different. That's why I'm asking</p> <p>As i said, that hack fixes the problem. But i don't believe that having to change the table name or escape the table name manually is the best solution. Doctrine should be doing that transparently, as it does for other situations (such as during schema creation). Why not during all other operations? Makes no sense at all.</p> <p>This is not a hack... In ORM, "`" is not the MySQL identifier quote. It is exactly thought as a character with which you tell the ORM that the identifier should be quoted.<br/> The default strategy does make use of it, so please use it.</p> <p>Also, we won't collect the SQL reserved keywords, nor we can know what keywords are used in all vendors. The patch for the quoting strategy was exactly thought to allow end users to use insecure names for their objects/fields/indexes/etc but without having the ORM implement those checks for them (since it would just be messy and too "magic").</p> <p>Please also reconsider your pull request on github too ( <a href="http://www.doctrine-project.org/jira/browse/DBAL-298" title="[GH-166] Fixes a bug caused by unquoted reserved table name being referenced during schema creation"><del>DBAL-298</del></a> ).</p> <p>I'm closing this one</p> <p>Then what's the purpose of Doctrine\DBAL\Platforms\Keywords\MySQLKeywords?</p> <p><a href="http://www.doctrine-project.org/jira/secure/ViewProfile.jspa?name=klaussilveira" class="user-hover" rel="klaussilveira">Klaus Silveira</a> not sure, but it isn't used in ORM.</p> <p>A related Github Pull-Request <span class="error">&#91;GH-166&#93;</span> was closed<br/> <a href="https://github.com/doctrine/dbal/pull/166" class="external-link">https://github.com/doctrine/dbal/pull/166</a></p>