http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DDC-1775 Doctrine 2 - ORM <p>New entities with Notify strategy for changes and with GeneratedValue(strategy="AUTO") never get the onPropertyChanged listener attached to them. That happens because of the logic in the UOW::scheduleForInsert($entity) method. The last condition in it "isset($this-&gt;entityIdentifiers<span class="error">&#91;$oid&#93;</span>)" is never true because the identifier is not set and therefore the code that attaches the PropertyChangedListener in addToIdentityMap is never run.</p> DDC-1775

Notify strategy listener is not attached for new entities

Bug Major Resolved Fixed All Benjamin Eberlei Oleg Namaka Wed, 11 Apr 2012 16:45:47 +0000 Sat, 7 Jul 2012 15:50:04 +0000 Sat, 7 Jul 2012 15:50:04 +0000 2.2.1 2.2.3 ORM 1 1 <p>This is intentional to me. <br/> According to code and documentation, PropertyChanged is supposed to operate over updates, never over inserts.</p> <p>I experimented changing the code to also notify about changed during new and the consequences were very drastic. Internally, propertyChanged creates entityChangesets that implies an UPDATE.</p> <p>Marking ticket as won't fix.</p> <p>In that case the Notify strategy is partially broken:<br/> Category entity:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">.............. *\Entity\Category * * @ORM\Table(name=<span class="code-quote">"category"</span>) * @ORM\Entity */ class Category <span class="code-keyword">implements</span> TimestampableInterface /** * Caption * * @<span class="code-keyword">var</span> string $caption * @ORM\Column(name=<span class="code-quote">"caption"</span>, type=<span class="code-quote">"text"</span>, nullable=<span class="code-keyword">true</span>) */ <span class="code-keyword">protected</span> $caption; /** * Added At * * @<span class="code-keyword">var</span> \DateTime $addedAt * * @ORM\Column(name=<span class="code-quote">"added_at"</span>, type=<span class="code-quote">"datetime"</span>, nullable=<span class="code-keyword">true</span>) */ <span class="code-keyword">protected</span> $addedAt; <span class="code-keyword">public</span> function setCaption($caption) { <span class="code-keyword">if</span> ($<span class="code-keyword">this</span>-&gt;caption != $caption) { $<span class="code-keyword">this</span>-&gt;_onPropertyChanged('caption', $<span class="code-keyword">this</span>-&gt;caption, $caption); $<span class="code-keyword">this</span>-&gt;caption = $caption; } } <span class="code-keyword">public</span> function setAddedAt($addedAt) { $oldValue = $<span class="code-keyword">this</span>-&gt;addedAt; $<span class="code-keyword">this</span>-&gt;addedAt = $addedAt; <span class="code-keyword">if</span> ((is_null($oldValue) || ($oldValue-&gt;getTimestamp() != $<span class="code-keyword">this</span>-&gt;addedAt-&gt;getTimestamp()))) { $<span class="code-keyword">this</span>-&gt;_onPropertyChanged('addedAt', $oldValue, $<span class="code-keyword">this</span>-&gt;addedAt); } } <span class="code-keyword">protected</span> function _onPropertyChanged($propName, $oldValue, $newValue) { <span class="code-keyword">if</span> ($<span class="code-keyword">this</span>-&gt;_listeners) { /** @<span class="code-keyword">var</span> $listener \Doctrine\Common\PropertyChangedListener */ foreach ($<span class="code-keyword">this</span>-&gt;_listeners as $listener) { $listener-&gt;propertyChanged($<span class="code-keyword">this</span>, $propName, $oldValue, $newValue); } } } <span class="code-keyword">public</span> function addPropertyChangedListener(PropertyChangedListener $listener) { $<span class="code-keyword">this</span>-&gt;_listeners[] = $listener; } .............. </pre> </div></div> <p>OnFlush event handler:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">.............. foreach ($uow-&gt;getScheduledEntityInsertions() as $entity) { <span class="code-keyword">if</span> ($entity <span class="code-keyword">instanceof</span> TimestampableInterface) { $entity-&gt;setUpdatedAt(<span class="code-keyword">new</span> \DateTime('now')); $entity-&gt;setAddedAt(<span class="code-keyword">new</span> \DateTime('now')); $uow-&gt;recomputeSingleEntityChangeSet($em-&gt;getClassMetadata(get_class($entity)), $entity); } } ............... </pre> </div></div> <p>Code that uses the entity:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> $cat = <span class="code-keyword">new</span> \Entity\Category(); <span class="code-comment">// @todo <span class="code-keyword">this</span> is a workaround until the http://www.doctrine-project.org/jira/browse/DDC-1775 is resolved </span> $cat-&gt;addPropertyChangedListener($<span class="code-keyword">this</span>-&gt;_em-&gt;getUnitOfWork()); $cat-&gt;setCaption('Please explain'); $<span class="code-keyword">this</span>-&gt;_em-&gt;persist($cat); $<span class="code-keyword">this</span>-&gt;_em-&gt;flush(); </pre> </div></div> <p>If there is no explicit call to the addPropertyChangedListener method, the caption field gets saved but the $addedAt remains null after flush. The entity does not have the attached listener so UnitOfWork does not know anything about the update that happened in the OnFlush event, and the recomputeSingleEntityChangeSet method skips entities with Notify strategy.</p> <p>Changing computeScheduleInsertsChangeSets() would solve this, but it would also mean that the notifier gets injected more than once. </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">private</span> function computeScheduleInsertsChangeSets() { foreach ($<span class="code-keyword">this</span>-&gt;entityInsertions as $entity) { $class = $<span class="code-keyword">this</span>-&gt;em-&gt;getClassMetadata(get_class($entity)); $<span class="code-keyword">this</span>-&gt;computeChangeSet($class, $entity); <span class="code-keyword">if</span> ($entity <span class="code-keyword">instanceof</span> NotifyPropertyChanged) { $entity-&gt;addPropertyChangedListener($<span class="code-keyword">this</span>); } } } </pre> </div></div> <p>I think injecting in scheduleForInsert() is ok, but we have to look at potential problems also</p> <p>Fixed</p>