http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DCOM-175 Doctrine Common <p>__sleep should not return private parent property names (see <a href="http://php.net/__sleep" class="external-link">http://php.net/__sleep</a>) this raises notices, and also results in the value of the property being 'N' (null) instead of keeping its value.</p> <p>I am unfortunately stuck having to serialize proxies in my revision tracking, as doctrine seems to be currently ignoring the fetch="EAGER" I set on the related properties.</p> <p>Proxies should use the Serializable interface, and not __sleep, or not return parent property names which are private, it serves no purpose, and is not supported by PHP itself anyway.</p> <p>Also, if you keep __sleep, but do not return the parent property names, then it will only include the items you return, so it would be better to simply drop the __sleep method, I cannot actually see any useful purpose it serves.</p> DCOM-175

Proxies return private properties in __sleep, which is not supported by PHP.

Bug Major In Progress Unresolved Marco Pivetta Ryan Mauger Tue, 27 Mar 2012 13:25:56 +0000 Fri, 19 Apr 2013 12:06:43 +0000 2.4 0 1 <p>just updated the issue body, realised that I worded something badly.</p> <p><a href="http://www.doctrine-project.org/jira/secure/ViewProfile.jspa?name=bittarman" class="user-hover" rel="bittarman">Ryan Mauger</a> I think that's a limitation we have. We use `__sleep` to avoid serializing fields like the initializers and the persisters of course.</p> <p>Even by implementing serializable, it would only work if the end user implemented it in the parent class.</p> <p>Tempted to mark it as "can't fix"</p> <p>I think there's a solution by having something like following:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> class SomeGeneratedProxyName <span class="code-keyword">extends</span> RealName <span class="code-keyword">implements</span> \Serializable { <span class="code-keyword">public</span> function unserialize($data) { $reflectionClass = <span class="code-keyword">new</span> ReflectionClass($<span class="code-keyword">this</span>); foreach ($reflectionClass-&gt;getProperties(ReflectionProperty::IS_PRIVATE) as $privateProp) { $privateProp-&gt;setAccessible(<span class="code-keyword">true</span>); $privateProp-&gt;setValue($<span class="code-keyword">this</span>, $data[$privateProp-&gt;getName()]); } <span class="code-comment">// ... other props ... </span> } <span class="code-keyword">public</span> function serialize() { $data = array(); $reflectionClass = <span class="code-keyword">new</span> ReflectionClass($<span class="code-keyword">this</span>); foreach ($reflectionClass-&gt;getProperties(ReflectionProperty::IS_PRIVATE) as $privateProp) { $privateProp-&gt;setAccessible(<span class="code-keyword">true</span>); $data[$privateProp-&gt;getName()] = $privateProp-&gt;getValue($<span class="code-keyword">this</span>); } <span class="code-comment">// ... other props ... </span> <span class="code-keyword">return</span> $data; } } </pre> </div></div> <p><a href="http://www.doctrine-project.org/jira/secure/ViewProfile.jspa?name=bittarman" class="user-hover" rel="bittarman">Ryan Mauger</a> I started implementing this one at <a href="https://github.com/Ocramius/common/compare/hotfix;DCOM-175" class="external-link">https://github.com/Ocramius/common/compare/hotfix;DCOM-175</a> and so far it looks promising. </p> <p>The only doubts so far are with handling cases like following:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> class MyEntity <span class="code-keyword">implements</span> Serializable { <span class="code-keyword">public</span> function serialize() { <span class="code-comment">// [...] </span> } <span class="code-keyword">public</span> function unserialize($serialized) { <span class="code-comment">// [...] </span> } <span class="code-keyword">public</span> function __sleep() { <span class="code-comment">// [...] </span> } <span class="code-keyword">public</span> function __wakeup() { <span class="code-comment">// [...] </span> } } </pre> </div></div> <p>So far I didn't get to write tests that demonstrate the exact behaviour for this case, but it looks like when `Serializable` is implemented, `_<em>sleep` and `</em>_wakeup` are ignored. Any thoughts on this?</p> <p>A possible solution is to use something like <a href="http://eval.in/16806" class="external-link">http://eval.in/16806</a>, and thus exploiting the ability of php to retrieve an object's private properties by using the special </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">chr(0) . 'Foo' . chr(0) . 'bar' </pre> </div></div> <p>trick.</p> <p>This can be abstracted by using </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">array_keys((array) $object);</pre> </div></div> <p>, which retrieves also those special keys</p>