http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DCOM-118 Doctrine Common <p>This issue is created automatically through a Github pull request on behalf of Seldaek:</p> <p> Url: <a href="https://github.com/doctrine/common/pull/195" class="external-link">https://github.com/doctrine/common/pull/195</a></p> <p>Message:</p> <p>If someone can take this and fix the issue it'd be great. I couldn't figure it out at a quick glance and I don't really have time, but it's a pretty messed up bug and not so trivial to debug if you don't know what happens in the background so I'd say it's pretty important.</p> DCOM-118

[GH-195] Add failing test to demonstrate parse error when @ is present in the description

Bug Major Open Unresolved Benjamin Eberlei Benjamin Eberlei Tue, 2 Oct 2012 15:19:06 +0000 Wed, 3 Oct 2012 04:27:17 +0000 0 1 <p>I digged a little deeper. The test case is a great one <img class="emoticon" src="http://www.doctrine-project.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/><br/> The DocLexer cuts ut -1 position from the first @ (which is the @ in the @example.com). so that the lexer has to process:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> o@example.com" * } * * @AnnotationTargetPropertyMethod(<span class="code-quote">"Bar"</span>) </pre> </div></div> <p>So that the catchable pattern: ("(?:<span class="error">&#91;^&quot;&#93;</span>|"")*") matches here to greedy (it matches string in quotes):</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> " * } * * @AnnotationTargetPropertyMethod(" </pre> </div></div> <p>As a result the lexer does not catch the correct @ from the Annotation</p> <p>I could not think of a fast fix for this. But maybe tomorrow.<br/> (leaving quoted string pattern with an @ was a wrong idea)</p> <p>Its not a workaround to do more or less cutting in the parser, because not-well-formed quoted strings would break anyway</p> <p>can someone think of a case, where a string (in some annotation) has a newline in it? Otherwise the tests do not fail, when I leave the string matching pattern with a newline.<br/> I still had another idea to restrict the position of a annotation more strictly to:</p> <ul class="alternate" type="square"> <li>the beginning of a new line (\s*&#42;\s* before)</li> <li>in another annotation</li> </ul> <p>but the second is not solvable with the lexer itself and would transfer the quoted string matching to the parser, because it needs context.</p> <p>I'll let seldaek pull, what I have (is this the right way?)</p>