http://www.doctrine-project.org/jira This file is an XML representation of an issue en-us 5.2.7 850 21-02-2013 http://www.doctrine-project.org/jira/browse/DC-755 Doctrine 1 <p>Replicating the bug:<br/> 1. Set ATTR_MODEL_CLASS_PREFIX non-null<br/> 2. create schema file with entity<br/> 3. run doctrine build-all<br/> 4. copy schema file<br/> 5. edit schema file to add column to entity<br/> 6. run generate-migrations-diff from copy of schema file to edited schema file</p> <p>Expected (previous) behaviour:<br/> Migration is generated to add the new column to entity</p> <p>Real behaviour:<br/> Drops entity from database and creates new</p> Current HEAD of Doctrine 1.2 DC-755

CLONE [DC-558] incorrect handling of MODEL_CLASS_PREFIX causes Doctrine_Migration_Diff to drop the whole database when working from YAML (Regression)

Bug Critical Open Unresolved Jonathan H. Wage Andrew Coulton Sun, 20 Jun 2010 09:58:04 +0000 Sun, 10 Oct 2010 18:51:58 +0000 1.2.3 Migrations 0 1 <p>This seems to be a regression caused by the fix for <a href="http://www.doctrine-project.org/jira/browse/DC-558" title="CLONE -generate-migrations-diff is producing bogus migrations (drops the whole database)"><del>DC-558</del></a> which added the MODEL_CLASS_PREFIX to the $_toPrefix in Doctrine_Migration_Diff::generateChanges.</p> <p>While this fixed the issue when generating diff from models to YAML, it has now created the reverse issue for generating diffs from YAML to YAML - as the models generated for the "from" schema do not get MODEL_CLASS_PREFIX prepended and so now this command will drop all existing tables and recreate.</p> <p>I believe the fix may be to amend as:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <div class="error"><span class="error">Unable to find source-code formatter for language: php.</span> Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml</div><pre> $from = $<span class="code-keyword">this</span>-&gt;_generateModels( Doctrine_Manager::getInstance()-&gt;getAttribute(Doctrine_Core::ATTR_MODEL_CLASS_PREFIX) . self::$_fromPrefix, $<span class="code-keyword">this</span>-&gt;_from); $to = $<span class="code-keyword">this</span>-&gt;_generateModels( Doctrine_Manager::getInstance()-&gt;getAttribute(Doctrine_Core::ATTR_MODEL_CLASS_PREFIX) . self::$_toPrefix, $<span class="code-keyword">this</span>-&gt;_to ); </pre> </div></div> <p>Since it seems that when presented with a folder of models _generateModels ignores the prefix anyway. However, I'm not sure of other impacts possible as a result?</p> <p>I've been using and testing the modified version above locally for some time and it seems to work as expected. Any chance of this making it into core? Otherwise, the migrations feature is completely unusable when working YAML-YAML and using model prefixes on the newly released 1.2.3</p> <p>Has anyone been able to produce this in a test case?</p> <p>I've attached a diff file with the DC755TestCase and the required from and to YAML schema files to reproduce this bug. I wasn't sure whether you prefer like this or as a git commit?</p> <p>Also attached a diff file of my proposed change to Doctrine_Migration_Diff to resolve this, but as I say unsure if it has implications on other migration types.</p> <p>Fixed by <a href="http://github.com/acoulton/doctrine1/tree/DC-755" class="external-link">http://github.com/acoulton/doctrine1/tree/DC-755</a></p>