[DDC-718] Bottleneck in computeAssociationChanges()? Created: 24/Jul/10 Updated: 24/Jul/10
|Project:||Doctrine 2 - ORM|
|Reporter:||Benjamin Eberlei||Assignee:||Roman S. Borschel|
It seems that since
Wouldn't it be better to save the "addedEntities" in an additional map inside "PersistentCollection" and retrieve those instead of calling $value->unwrap() ?
|Comment by Roman S. Borschel [ 24/Jul/10 ]|
Do you have any numbers to back this up? With large, hydrated collections the bottlenecks are likely elsewhere (SQL query, hydration)
Further, maintaining "addedEntities" is not as trivial as you might think. The current approach does not care about what happens in-between, it just computes a diff between the old and new state of the collection at commit time. Tracking added/removed objects as they come in and go is more cumbersome.
|Comment by Benjamin Eberlei [ 24/Jul/10 ]|
no numbers, i was just confused about the code, because i remembered it differently