[DDC-577] Change default allocationSize from 10 to 1 Created: 07/May/10  Updated: 12/Aug/10  Resolved: 13/Jun/10

Status: Closed
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0-BETA1
Fix Version/s: 2.0-BETA3
Security Level: All

Type: Improvement Priority: Major
Reporter: Jan Tichý Assignee: Benjamin Eberlei
Resolution: Fixed Votes: 0
Labels: None


 Description   

I propose to change the default value of allocationSize for sequence columns from current 10 to 1. It's defined in $definition['allocationSize'] in Doctrine/ORM/Mapping/ClassMetaFactory.php.

The improvement request is based on detailed discussion on http://www.doctrine-project.org/jira/browse/DDC-569?focusedCommentId=12855&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12855

Current default value for allocationSize=10 is CONFUSING and I am sure it will cause problems and misunderstoods for many people in future.

The core of the problem is that lot of people define table structure manually, separately from entity annotations. And while the default allocationSize is 10, they have to remember (and they have to know they should remember) each time they write new table and new entity, that:

a) They have to define each the sequence in database manually with INCREMENT BY 10
b) OR they have to define in each entity manually the annotation for @SequenceGenerator - allocationSize=1
c) OR they have to manually use strategy="IDENTITY", but it's primarily related to primary keys, not to all sequences at general.

Shortly, in an intuitive way everybody assumes the behaviour as allocationSize would be 1. Current default value 10 is not in accord with this intuitive perception and will cause many questions and misunderstoods.

The "preloading" of 10 values at once is a kind of "advanced optimalization" - it's great it is available and implemented - but it should not be applied automatically, but only after explicit setup.



 Comments   
Comment by Roman S. Borschel [ 05/Jun/10 ]

This should be changed for BETA3.

Comment by Benjamin Eberlei [ 13/Jun/10 ]

Fixed and scheduled for 2.0 BETA 3

Comment by Guilherme Blanco [ 12/Aug/10 ]

Actually patch was only committed now.

http://github.com/doctrine/doctrine2/commit/5719f8523bbb3c8a6fd11c749e5317b238d3d2b3

Generated at Tue Oct 21 09:01:13 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.