[DDC-359] Specified, but empty CLI Options --option= causes Notice undefined offset: 0 [Test case for CliController included] Created: 21/Feb/10  Updated: 14/Jun/10  Resolved: 18/Mar/10

Status: Resolved
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0-ALPHA4
Fix Version/s: 2.0-BETA1
Security Level: All

Type: Bug Priority: Minor
Reporter: Nils Adermann Assignee: Jonathan H. Wage
Resolution: Fixed Votes: 0
Labels: None
Environment:

PHP 5.3.1


Attachments: File cli_controller_tests.diff     File empty_option_bug.diff    
Issue Links:
Reference
relates to DDC-222 Create unit tests for CLI components Closed

 Description   

Specified, but empty CLI Options --option= cause a Notice (undefined offset: 0)

This problem also exists in trunk.

What I ran:

naderman@Chaumont:~/projects/doctrine/Doctrine-trunk/tools/sandbox$ ./doctrine Orm:generate-proxies --class-dir=

Expected output:

Doctrine Command Line Interface

No classes to process.

Actual output:

PHP Notice:  Undefined offset: 0 in /home/naderman/projects/doctrine/Doctrine-trunk/lib/Doctrine/Common/Cli/CliController.php on line 230
PHP Stack trace:
PHP   1. {main}() /home/naderman/projects/doctrine/Doctrine-trunk/tools/sandbox/doctrine:0
PHP   2. include() /home/naderman/projects/doctrine/Doctrine-trunk/tools/sandbox/doctrine:4
PHP   3. Doctrine\Common\Cli\CliController->run() /home/naderman/projects/doctrine/Doctrine-trunk/tools/sandbox/doctrine.php:12
PHP   4. Doctrine\Common\Cli\CliController->_processArguments() /home/naderman/projects/doctrine/Doctrine-trunk/lib/Doctrine/Common/Cli/CliController.php:127
Doctrine Command Line Interface

Orm:generate-proxies => The supplied configuration uses the annotation metadata driver. The 'class-dir' argument is required for this driver.

I decided to write a patch and a test case for the issue but it turns out there aren't any tests for CliController, so I added some. You can find the result attached. Not sure if you can still call this "unit" test but it looks to me like the best you can currently do and should work quite well.

I also came across another problem in CliController where it incorrectly refers to AbstractPrinter, rather than Printers\AbstractPrinter which is now included in the patch for the original bug.

I'm not sure what your guideline on @author tags is, I added them to the test case and the TaskMock class now, but feel free to remove them if you like. Some of Doctrine's files seem to have them and some not.



 Comments   
Comment by Jonathan H. Wage [ 18/Mar/10 ]

Thanks for the bug report and awesome patch/test case!

Generated at Wed Sep 17 13:35:49 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.