[DDC-2472] [GH-677] Type fix in ORM\PersistentCollection Created: 27/May/13  Updated: 10/Aug/13  Resolved: 10/Aug/13

Status: Resolved
Project: Doctrine 2 - ORM
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

Type: Bug Priority: Major
Reporter: Doctrine Bot Assignee: Benjamin Eberlei
Resolution: Invalid Votes: 0
Labels: None


This issue is created automatically through a Github pull request on behalf of michaldudek:

Url: https://github.com/doctrine/doctrine2/pull/677


The ```ORM\PersistentCollection``` class accepts anything as 3rd argument to its constructor while it should be either array or ```Collection``` object. The ```$this->coll``` phpdoc says that it's a ```Collection``` while the constructor's phpdoc says it's an array.

The class assumes ```Collection``` but there isn't any type check at all. I have added conversion of array into ```ArrayCollection``` in the constructor as in some (very unclear) cases it likes to die with a fatal error:

```Fatal error: Call to a member function add() on a non-object in Doctrine/ORM/PersistentCollection.php on line 169```

Comment by Doctrine Bot [ 27/May/13 ]

A related Github Pull-Request [GH-677] was closed:

Generated at Tue Dec 01 17:17:03 EST 2015 using JIRA 6.4.10#64025-sha1:5b8b74079161cd76a20ab66dda52747ee6701bd6.