[DDC-2273] [GH-566] Added missing return statement to AbstractCommand. Created: 03/Feb/13 Updated: 05/Feb/13 Resolved: 05/Feb/13 |
|
| Status: | Resolved |
| Project: | Doctrine 2 - ORM |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.4 |
| Security Level: | All |
| Type: | Bug | Priority: | Major |
| Reporter: | Benjamin Eberlei | Assignee: | Benjamin Eberlei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
This issue is created automatically through a Github pull request on behalf of BenMorel: Url: https://github.com/doctrine/doctrine2/pull/566 Message: The `AbstractCommand::execute()` method should return an `integer`, or `null`. Although in PHP, omitting the `return` statement is equivalent to returning `null`, it is recommended to put an explicit `return` to clearly differentiate it from `return void`. I've added `return 0;` here, keeping the existent behavior. |
| Comments |
| Comment by Benjamin Eberlei [ 03/Feb/13 ] |
|
A related Github Pull-Request [GH-566] was closed |
| Comment by Fabio B. Silva [ 05/Feb/13 ] |
|
Merged : https://github.com/doctrine/doctrine2/commit/d3cbdfcafa3e8dbb1d3f7029f31eb6412855c097 |