[DDC-2184] [GH-530] Singular form of generated methods should end with 'y' when property ends with 'ies' Created: 04/Dec/12 Updated: 06/Jan/13 |
|
| Status: | In Progress |
| Project: | Doctrine 2 - ORM |
| Component/s: | Tools |
| Affects Version/s: | 2.3 |
| Fix Version/s: | None |
| Security Level: | All |
| Type: | Improvement | Priority: | Major |
| Reporter: | Benjamin Eberlei | Assignee: | Benjamin Eberlei |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
In Doctrine 2.3 the 'add' and 'remove' methods in oneToMany associations have another problem (in earlier versions like 2.2 this worked correct). The singular form is not correctly detected if the property ends with 'ies' like 'entries' which should be transformed to 'entry'.
Archive:
type: entity
fields:
id:
id: true
type: integer
unsigned: false
nullable: false
generator:
strategy: IDENTITY
oneToMany:
entries:
targetEntity: Entry
mappedBy: archive
This generates these methods: public function addEntrie(\Entry $entries) { ... } public function removeEntrie(\Entry $entries) { ... } Because in the EntityGenerator only the plural 's' is removed. It would be nice if an ending of 'ies' could be replaced by 'y'. So that we get these methods public function addEntry(\Entry $entries) { ... } public function removeEntry(\Entry $entries) { ... } My fork already has the changes https://github.com/naitsirch/doctrine-orm2/commit/a3adfccb4927d61da7debae46ed0fff61e4212f8 |
| Comments |
| Comment by Christian Stoller [ 04/Dec/12 ] |
|
Sorry, I accidently clicked on the button 'Request Feedback' |
| Comment by Benjamin Eberlei [ 06/Jan/13 ] |
|
Mark as improvement |