[DDC-113] Cascaded persist avoids LifecycleCallbacks Created: 04/Nov/09  Updated: 18/Dec/09  Resolved: 18/Dec/09

Status: Closed
Project: Doctrine 2 - ORM
Component/s: ORM
Affects Version/s: 2.0-ALPHA3
Fix Version/s: 2.0-ALPHA4
Security Level: All

Type: Bug Priority: Critical
Reporter: Nico Kaiser Assignee: Roman S. Borschel
Resolution: Fixed Votes: 0
Labels: None


 Description   

When an Entity is created by 'cascade=

{"persist"}

', its LifecycleCallbacks (e.g. "PrePersist"!) are not invoked.

When it is persisted explicitly, everything workes fine and the events are called...



 Comments   
Comment by Benjamin Eberlei [ 11/Dec/09 ]

Works for me on trunk, added test-case that proves it (Doctrine\Tests\ORM\Functional\LifecycleCallbackTest::testCascadedEntitiesCallsPrePersist())

Comment by Nico Kaiser [ 14/Dec/09 ]

There is still an issue. You can reproduce it if you change the test case slightly to this:

    /**
     * @group DDC-113
     */
    public function testCascadedEntitiesCallsPrePersist()
    {
        $e1 = new LifecycleCallbackTestEntity;
        $e2 = new LifecycleCallbackTestEntity;

        $c = new LifecycleCallbackCascader();
        
        $this->_em->persist($c);
        
        $c->entities[] = $e1;
        $c->entities[] = $e2;

        //$this->_em->persist($c);
        $this->_em->flush();

        $this->assertTrue($e1->prePersistCallbackInvoked);
        $this->assertTrue($e2->prePersistCallbackInvoked);
    }

The difference to the existing (and indeed working) test case is that the Cascader entity is persisted before the collection entries are added.

Comment by Benjamin Eberlei [ 14/Dec/09 ]

That is valid behaviour according to the lifecycle of an entity, persist gets cascaded right and only when ->persist() is called.

In the case you show, the two entities are also not persisted, because the cascade was already executed.

Comment by Nico Kaiser [ 14/Dec/09 ]

From a technical point of view this is ok - but from an intuitive point of view I would think I can use persist whereever I want. So I can create an entity, persist it (so it gets written to the DB), make changes to it (like adding entities to its collection) and getting its saved (and the collection entities persisted) when I call flush().

So I suspect lifecycle events to be called whenever an entity is persisted. And in this case LifecycleCallbackTestEntity's are persisted automatically by flush() (and this is after the Cascader is persisted!), so lifecycle events should fire here.

Comment by Roman S. Borschel [ 17/Dec/09 ]

I have a fix for this ready, however, I want to look into something else before committing. I'll address this over the weekend.

Comment by Roman S. Borschel [ 18/Dec/09 ]

Should be fixed now.

Generated at Sat Dec 20 17:59:55 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.