[DCOM-46] Make annotation index configurable Created: 07/Apr/11 Updated: 13/May/11 Resolved: 13/May/11 |
|
| Status: | Resolved |
| Project: | Doctrine Common |
| Component/s: | Annotations |
| Affects Version/s: | 2.1 |
| Fix Version/s: | 2.1 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Johannes Schmitt | Assignee: | Guilherme Blanco |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
So, this is another improvement that I'd like to make. Right now all annotations are indexed by their name which has the limitation that on the top level annotations with the same name are only gathered once. /**
* @param mixed $a
* @param mixed $a
* @param mixed $a
*/
function ($a, $b, $c) { }
In the above case the annotation parser would only pick up one "param" annotation. My guess is that this was done for fast lookups, but I think we need to make this configurable (I know you hate this word /**
* @params({@param, @param, @param})
*/
function($a, $b, $c) {}
This only requires two lines to be changed/made conditional, see p.s. If you want me to provide a patch for this, just tell me. |
| Comments |
| Comment by Guilherme Blanco [ 13/May/11 ] |
|
Implemented on master. https://github.com/doctrine/common/commit/59910f53fad7ce08a1ec840d9874a74cefcf32b8 |