[DCOM-128] RedisCache uses IGBINARY which is not always available Created: 20/Oct/12  Updated: 03/Dec/13  Resolved: 03/Dec/13

Status: Resolved
Project: Doctrine Common
Component/s: Caching
Affects Version/s: 2.3
Fix Version/s: 2.4

Type: New Feature Priority: Minor
Reporter: Sander Marechal Assignee: Marco Pivetta
Resolution: Fixed Votes: 0
Labels: None


 Description   

The RedisCache uses Redis::SERIALIZER_IGBINARY. See https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Cache/RedisCache.php line 47.

The problem is that the php Redis extension can be compiled without IGBINARY support. In that case, this code causes a fatal error because the constant does not exist.

The DotDeb package of php5-redis (often used on Debian systems) for example comes compiled without IGBINARY support.

The code should probably check if the constant exists. If not, the default to Redis::SERIALIZER_PHP



 Comments   
Comment by Peter Mitchell [ 24/Jun/13 ]

This appears like it will be fixed when 2.4 is released https://github.com/doctrine/cache/blob/master/lib/Doctrine/Common/Cache/RedisCache.php#L128

Comment by Marco Pivetta [ 03/Dec/13 ]

Already fixed in master

Generated at Mon Sep 22 02:21:10 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.