[DC-978] Doctrine_Connection_Mssql dies on modifyLimitSubquery every time Created: 27/Feb/11 Updated: 27/Feb/11
|Reporter:||Andrej Pavlovic||Assignee:||Jonathan H. Wage|
Looking at the latest version of Doctrine_Connection_Mssql in git repo:
In Doctrine_Query:getLimitSubquery() there is a call to Doctrine_Connection_Mssql::modifyLimitSubquery().
This in turn calls Doctrine_Connection_Mssql::modifyLimitQuery() wihtout passing the $queryOrigin parameter:
From just looking at the above code, the query chokes on the first call to a $queryOrigin method. It seems like there is a lot of missing code here which should work with the $query directly when $queryOrigin is not available...
What is the point of $orderbySql and $orderbyDql variables when they are not used anywhere?
This code looks like it's half way done and untested.