[DBAL-590] Doctrine\DBAL\Schema\Column::visit Calls a Method That Doesn't Exist on Doctrine\DBAL\Scema\Visitor\Visitor Created: 27/Aug/13  Updated: 01/Jan/14  Resolved: 01/Jan/14

Status: Resolved
Project: Doctrine DBAL
Component/s: Schema Managers
Affects Version/s: 2.4, 2.3.4
Fix Version/s: 2.5

Type: Bug Priority: Minor
Reporter: Christopher Davis Assignee: Benjamin Eberlei
Resolution: Fixed Votes: 0
Labels: None
Environment:

$ php -v
PHP 5.4.15 (cli) (built: Aug 16 2013 15:38:16)
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2013 Zend Technologies
with Xdebug v2.2.1, Copyright (c) 2002-2012, by Derick Rethans

$ uname -a
Darwin chrispmg.local 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64



 Description   

`Column::visit` tries to `Doctrine\DBAL\Schema\Visitor\Visitor::accept`

https://github.com/doctrine/dbal/blob/2.3/lib/Doctrine/DBAL/Schema/Visitor/Visitor.php#L42
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/Column.php#L471

It doesn't look like `Visitor` actually has an `accept` method.
https://github.com/doctrine/dbal/blob/2.3/lib/Doctrine/DBAL/Schema/Visitor/Visitor.php
https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/Visitor/Visitor.php

The method needed seems to be `Visitor:: acceptColumn`, but `Column` itself doesn't seem to be aware of it's parent table in any way.



 Comments   
Comment by Benjamin Eberlei [ 01/Jan/14 ]

Removed the method, the Table#visit() method is responsible for this.

Generated at Thu Nov 27 17:25:18 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.