[DBAL-470] [GH-291] Optimize abstract platform Created: 24/Mar/13  Updated: 22/Dec/13  Resolved: 16/Nov/13

Status: Resolved
Project: Doctrine DBAL
Component/s: None
Affects Version/s: None
Fix Version/s: None
Security Level: All

Type: Bug Priority: Major
Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei
Resolution: Fixed Votes: 0
Labels: None


 Description   

This issue is created automatically through a Github pull request on behalf of deeky666:

Url: https://github.com/doctrine/dbal/pull/291

Message:

This PR optimizes the <code>AbstractPlatform</code> class in the following ways:

  • Add dedicated use statemtent for each class import
  • Add missing class imports
  • Add missing phpDoc blocks for methods
  • Fix existing phpDocs (parameters, return types, @throws tags, FQDN types, indentation etc.)
  • "Normalize" phpDocs (consistent verbs for what a method does, reuse of certain phrases for similar method types etc.)
  • Fix CS
  • Improve certain code portions

I hope this is a welcomed improvement. It reads much better now and feels somewhat cleaner to me.



 Comments   
Comment by Doctrine Bot [ 20/Aug/13 ]

A related Github Pull-Request [GH-291] was closed:
https://github.com/doctrine/common/pull/291

Comment by Fabio B. Silva [ 16/Nov/13 ]

Closed ... See : https://github.com/doctrine/common/pull/291 for more details..

Comment by Steve Müller [ 18/Nov/13 ]

@Fabio: Are you sure your comment is related to this issue? Looks like the PR you referenced is from Common repository but this ticket is related to DBAL...

Comment by Doctrine Bot [ 22/Dec/13 ]

A related Github Pull-Request [GH-291] was closed:
https://github.com/doctrine/dbal/pull/291

Generated at Fri Aug 22 05:59:30 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.