[DBAL-302] [GH-168] DebugStack should ignore stopQuery when disabled Created: 09/Jul/12 Updated: 10/Jul/12 Resolved: 10/Jul/12 |
|
| Status: | Resolved |
| Project: | Doctrine DBAL |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.3 |
| Security Level: | All |
| Type: | Bug | Priority: | Major |
| Reporter: | Benjamin Eberlei | Assignee: | Benjamin Eberlei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
This issue is created automatically through a Github pull request on behalf of dpb587: Url: https://github.com/doctrine/dbal/pull/168 Message: I noticed that DebugStack was adding an empty element when it was disabled. This PR changes it to match startQuery with its behavior. 1) Doctrine\Tests\DBAL\Logging\DebugStackTest::testLoggedQueryDisabled I've submitted the PR to 2.0.x since that's where the bug is first seen and is still listed as stable on doctrine-project.org. Preferably this could also be applied to newer branches as well, or I can also submit separate PRs. |
| Comments |
| Comment by Benjamin Eberlei [ 09/Jul/12 ] |
|
A related Github Pull-Request [GH-168] was closed |