[DBAL-302] [GH-168] DebugStack should ignore stopQuery when disabled Created: 09/Jul/12  Updated: 10/Jul/12  Resolved: 10/Jul/12

Status: Resolved
Project: Doctrine DBAL
Component/s: None
Affects Version/s: None
Fix Version/s: 2.3
Security Level: All

Type: Bug Priority: Major
Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei
Resolution: Fixed Votes: 0
Labels: None


This issue is created automatically through a Github pull request on behalf of dpb587:

Url: https://github.com/doctrine/dbal/pull/168


I noticed that DebugStack was adding an empty element when it was disabled. This PR changes it to match startQuery with its behavior.

1) Doctrine\Tests\DBAL\Logging\DebugStackTest::testLoggedQueryDisabled
Failed asserting that two arrays are equal.
— Expected
+++ Actual
@@ @@
+ [0] => Array
+ (
+ [executionMS] => 1341871660.9651
+ )

I've submitted the PR to 2.0.x since that's where the bug is first seen and is still listed as stable on doctrine-project.org. Preferably this could also be applied to newer branches as well, or I can also submit separate PRs.

Comment by Benjamin Eberlei [ 09/Jul/12 ]

A related Github Pull-Request [GH-168] was closed

Generated at Fri Jul 31 03:11:42 UTC 2015 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.