[DBAL-202] Preparing Statements outside Transaction Created: 15/Jan/12  Updated: 17/Apr/14  Resolved: 05/May/12

Status: Resolved
Project: Doctrine DBAL
Component/s: Drivers
Affects Version/s: None
Fix Version/s: None
Security Level: All

Type: Bug Priority: Major
Reporter: Benjamin Eberlei Assignee: Benjamin Eberlei
Resolution: Fixed Votes: 0
Labels: None


 Description   

From the mailing list:

I'm using DBAL 2.1 with Oracle and it appears that if I call prepare() for my SQL and cache the prepared statement for later, if I then start a new transaction and call execute() on the statement, it commits the transaction. Is this behavior intentional? If so, does that mean I have to prepare my statement anew for every transaction?

Note that I'm seeing the aforementioned behavior with code as basic as the following:

$stmt = $dbh->prepare("INSERT INTO test_table (id, description) VALUES
(:my_id, :my_desc)");
$dbh->beginTransaction();
$stmt->execute(array(":my_id" => 1, ":my_desc" => "test"));
$dbh->rollBack();

After executing the above, a record has been committed to the db. If I had a more complex scenario involving a transaction with multiple statements where the entire transaction is inside a loop, this becomes problematic--I can't then prepare my statements outside the loop to improve performance.

When I try the same thing using straight PDO, it works fine. Can anyone else confirm this behavior?



 Comments   
Comment by Benjamin Eberlei [ 15/Jan/12 ]

Are you using PDO_OCI or oci8 with Doctrine?

Comment by Danny Berger [ 15/Jan/12 ]

I had responded to him on our intranet and intended to submit a patch, but haven't yet found the time to prepare and test one. As a temporary workaround I suggested he prepare the statement inside the transaction. We are using oci8 and the following was my response and analysis:

When the doctrine2 oci8 driver prepares a statement, the generated statement will forever use the active execute mode, regardless of the mode when it's actually executed. I disagree with the current behavior.

As you noted, this is not the behavior used by PDO OCI. Short-term, I think you should prepare the statement inside a transaction. Long-term, I think we should submit a patch to doctrine2, something like follows:

  • add a `getExecuteMode` to `OCI8Connection`
  • add a `getDriverOptions` to `OCI8Connection`
  • remove the `$executeMode` parameter from `OCI8Statement::__construct`
  • remove the `$driverOptions` parameter from `OCI8Statement::__construct`
  • store a reference to `$dbh` to `$this->dbh` from `OCI8Statement::_construct`
  • replace `$this->_executeMode` with `$this->_dbh->getExecuteMode()`
  • replace `$this->_driverOptions` with `$this->_dbh->getDriverOptions()`
Comment by Danny Berger [ 28/Apr/12 ]

Created an independent test - https://gist.github.com/2515100
Submitted a pull request - https://github.com/doctrine/dbal/pull/137

Generated at Thu Nov 20 20:58:34 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.