[DBAL-195] Method AbstractSchemaManager->dropAndCreateSequence() contains erroneous code. Created: 06/Jan/12  Updated: 09/Jan/12  Resolved: 09/Jan/12

Status: Resolved
Project: Doctrine DBAL
Component/s: Schema Managers
Affects Version/s: 2.1.5
Fix Version/s: 2.1.6, 2.2
Security Level: All

Type: Bug Priority: Major
Reporter: Marc Campeau Assignee: Benjamin Eberlei
Resolution: Fixed Votes: 0
Labels: None

Attachments: Text File AbstractSchemaManager_dropAndCreateSequence.patch    

 Description   

I needed to use the function and looking at the code I found that it seemed partially implemented, cut and pasted from something else or just not ported from an earlier implementation. I'm now submitting a patch that fixes this issue. I didn't modify the AbstractSchemaManager->dropSequence($name) signature to become AbstractSchemaManager->dropSequence($sequence) but it might be a good idea to refactor it (guess that would be another issue though )



 Comments   
Comment by Benjamin Eberlei [ 09/Jan/12 ]

Oh the code worked before, but was refactored. This method was forgotten.

Comment by Benjamin Eberlei [ 09/Jan/12 ]

Fixed.

Generated at Thu Jul 31 23:59:46 UTC 2014 using JIRA 6.2.3#6260-sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.