Doctrine PHPCR
  1. Doctrine PHPCR
  2. PHPCR-77

document level options inheritance

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Labels:
      None

      Description

      documents extending other documents should inherit the global attributes unless overwritten explicitly.

      for example, having @Document(referenceable=true) should be kept for an extending class unless it explicitly sets it to false. currently, attributes are reset on each new @Document tag. (i assume we have the same issue for xml/yml mapping?)

        Activity

        Hide
        David Buchmann added a comment -

        this is fixed for referenceable in https://github.com/doctrine/phpcr-odm/pull/185

        Show
        David Buchmann added a comment - this is fixed for referenceable in https://github.com/doctrine/phpcr-odm/pull/185
        Hide
        David Buchmann added a comment -

        when doing this, we should also fix MappedSuperclass annotation to support all attributes the Document has. in xml mappings mapped-superclass extends document

        Show
        David Buchmann added a comment - when doing this, we should also fix MappedSuperclass annotation to support all attributes the Document has. in xml mappings mapped-superclass extends document
        Show
        David Buchmann added a comment - https://github.com/doctrine/phpcr-odm/pull/294

          People

          • Assignee:
            Lukas Kahwe
            Reporter:
            David Buchmann
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: