Doctrine PHPCR

repository::createDocument is never called

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Labels:
    None

Description

i tried using repositories. see

https://github.com/symfony-cmf/ChainRoutingBundle/commit/12515f82b02c4a1ef230b05133ec89e03c1af2e0
https://github.com/symfony-cmf/ChainRoutingBundle/commit/edd9f9544eadedb142fefd3ea9bb0c3b293c59d5

however, from looking at the uow code i have the impression that createDocument is never called on DocumentRepository but directly in UOW. shouldn't the uow fetch the repository and build the document with the repository? effectively moving UOW::createDocument impl. to the base repository?

Activity

Descending order - Click to sort in ascending order
Hide
Permalink
Lukas Kahwe added a comment -

removed the method

Show
Lukas Kahwe added a comment - removed the method
Hide
Permalink
Lukas Kahwe added a comment -

none of the other ODM/ORM seem to have a create*() method in the repository. i suspect using a listener is the right approach and we should remove that method from the DocumentRepository.

Show
Lukas Kahwe added a comment - none of the other ODM/ORM seem to have a create*() method in the repository. i suspect using a listener is the right approach and we should remove that method from the DocumentRepository.

People

  • Assignee:
    Lukas Kahwe
    Reporter:
    David Buchmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: