Doctrine PHPCR
  1. Doctrine PHPCR
  2. PHPCR-42

sync the xml/yml mapping driver with the annotation driver

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      especially the locale/version stuff is not yet supported. but also the reference mapping seems to look quite different.

        Activity

        Hide
        Lukas Kahwe added a comment -

        seems to me like reference/referrer/translation/versioning is all done .. so if there is anything left .. please open a new ticket

        Show
        Lukas Kahwe added a comment - seems to me like reference/referrer/translation/versioning is all done .. so if there is anything left .. please open a new ticket
        Hide
        David Buchmann added a comment -

        actually mapped superclass seems to be relevant, but i did not yet understand it and the doc about it should be updated. see discussion in https://github.com/doctrine/phpcr-odm/pull/144#issuecomment-7095570

        Show
        David Buchmann added a comment - actually mapped superclass seems to be relevant, but i did not yet understand it and the doc about it should be updated. see discussion in https://github.com/doctrine/phpcr-odm/pull/144#issuecomment-7095570
        Hide
        David Buchmann added a comment -

        also, the mapped superclass feature makes no sense with phpcr-odm, we can simply inherit from document classes.

        Show
        David Buchmann added a comment - also, the mapped superclass feature makes no sense with phpcr-odm, we can simply inherit from document classes.
        Hide
        David Buchmann added a comment - - edited

        the pull request by craig has meanwhile been merged.

        there is still a bit of issues:

        the driver looks for the non-namespaced file. i.e. No mapping file found named '/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/routing-extra-bundle/Symfony/Cmf/Bundle/RoutingExtraBundle/Resources/config/doctrine/Route.phpcr.xml' for class 'Symfony\Cmf\Bundle\RoutingExtraBundle\Document\Route'.

        but if i put that file there and have an error, he tells me Invalid mapping file 'Symfony.Cmf.Bundle.RoutingExtraBundle.Document.Route.phpcr.xml'

        so the name determiner seems to be off a bit

        Show
        David Buchmann added a comment - - edited the pull request by craig has meanwhile been merged. there is still a bit of issues: the driver looks for the non-namespaced file. i.e. No mapping file found named '/home/david/liip/symfony-cmf/cmf-sandbox/vendor/symfony-cmf/routing-extra-bundle/Symfony/Cmf/Bundle/RoutingExtraBundle/Resources/config/doctrine/Route.phpcr.xml' for class 'Symfony\Cmf\Bundle\RoutingExtraBundle\Document\Route'. but if i put that file there and have an error, he tells me Invalid mapping file 'Symfony.Cmf.Bundle.RoutingExtraBundle.Document.Route.phpcr.xml' so the name determiner seems to be off a bit
        Hide
        Craig Marvelley added a comment -

        I've opened a PR here, there's still a bit left to be done that I'm hoping to add in the next few days.

        https://github.com/doctrine/phpcr-odm/pull/144

        Show
        Craig Marvelley added a comment - I've opened a PR here, there's still a bit left to be done that I'm hoping to add in the next few days. https://github.com/doctrine/phpcr-odm/pull/144

          People

          • Assignee:
            Lukas Kahwe
            Reporter:
            Lukas Kahwe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: