Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      • Annotation to map node name to a field (read-only except when creating a document). should be NodeName because NAME is one of the property types.
      • Align the annotations with the PHPCR\PropertyType types and map all types (missing for example the PATH type).

        Activity

        Hide
        David Buchmann added a comment -

        i just had a look at this and we are missing the following property types. i added them in https://github.com/doctrine/phpcr-odm/commit/a6032f8dc6574e0ce269653a884eb91ea5234284

        • Double
        • Name
        • Path
        • URI
        • Decimal

        On the other hand, Int and Float do not exist. i declared them as convenience alias for Long and Double, as people gessing property names might expect them. ok?
        What are the annotations EmbeddedDocument, EmbedOne supposed to do? We should either make them do something or remove them.

        What about Tests? I see we only have some tests of annotations and xml/yml mapping, but not for all annotations. Should we do them? Where would be the right place for them?

        Further, we are missing annotations for the node name and for the parent node. The later should be similar to the child annotation.

        Show
        David Buchmann added a comment - i just had a look at this and we are missing the following property types. i added them in https://github.com/doctrine/phpcr-odm/commit/a6032f8dc6574e0ce269653a884eb91ea5234284 Double Name Path URI Decimal On the other hand, Int and Float do not exist. i declared them as convenience alias for Long and Double, as people gessing property names might expect them. ok? What are the annotations EmbeddedDocument, EmbedOne supposed to do? We should either make them do something or remove them. What about Tests? I see we only have some tests of annotations and xml/yml mapping, but not for all annotations. Should we do them? Where would be the right place for them? Further, we are missing annotations for the node name and for the parent node. The later should be similar to the child annotation.
        Hide
        David Buchmann added a comment -

        this is cleaned up now

        Show
        David Buchmann added a comment - this is cleaned up now

          People

          • Assignee:
            David Buchmann
            Reporter:
            David Buchmann
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: