Doctrine Project

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Doctrine PHPCR
  • Doctrine PHPCR
  • PHPCR-15

Node property mappings

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Labels:
    None

Description

  • Annotation to map node name to a field (read-only except when creating a document). should be NodeName because NAME is one of the property types.
  • Align the annotations with the PHPCR\PropertyType types and map all types (missing for example the PATH type).

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • History
  • Activity
  • Source
Hide
Permalink
David Buchmann added a comment - 10/Oct/11 8:05 AM

i just had a look at this and we are missing the following property types. i added them in https://github.com/doctrine/phpcr-odm/commit/a6032f8dc6574e0ce269653a884eb91ea5234284

  • Double
  • Name
  • Path
  • URI
  • Decimal

On the other hand, Int and Float do not exist. i declared them as convenience alias for Long and Double, as people gessing property names might expect them. ok?
What are the annotations EmbeddedDocument, EmbedOne supposed to do? We should either make them do something or remove them.

What about Tests? I see we only have some tests of annotations and xml/yml mapping, but not for all annotations. Should we do them? Where would be the right place for them?

Further, we are missing annotations for the node name and for the parent node. The later should be similar to the child annotation.

Show
David Buchmann added a comment - 10/Oct/11 8:05 AM i just had a look at this and we are missing the following property types. i added them in https://github.com/doctrine/phpcr-odm/commit/a6032f8dc6574e0ce269653a884eb91ea5234284 Double Name Path URI Decimal On the other hand, Int and Float do not exist. i declared them as convenience alias for Long and Double, as people gessing property names might expect them. ok? What are the annotations EmbeddedDocument, EmbedOne supposed to do? We should either make them do something or remove them. What about Tests? I see we only have some tests of annotations and xml/yml mapping, but not for all annotations. Should we do them? Where would be the right place for them? Further, we are missing annotations for the node name and for the parent node. The later should be similar to the child annotation.
Hide
Permalink
David Buchmann added a comment - 22/Oct/11 1:03 PM

this is cleaned up now

Show
David Buchmann added a comment - 22/Oct/11 1:03 PM this is cleaned up now

People

  • Assignee:
    David Buchmann
    Reporter:
    David Buchmann
Vote (0)
Watch (0)

Dates

  • Created:
    30/Jul/11 12:52 PM
    Updated:
    22/Oct/11 1:03 PM
    Resolved:
    22/Oct/11 1:03 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Doctrine Project. Try JIRA - bug tracking software for your team.