Uploaded image for project: 'Doctrine PHPCR'
  1. Doctrine PHPCR
  2. PHPCR-109

Why Generic::getNodename and not camelcase?

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Labels:
      None

      Description

      Is there a reason why the get node name method on the generic document is ->getNodename and not ->getNodeName?

        Activity

        dantleech Daniel Leech created issue -
        Hide
        dbu David Buchmann added a comment -

        because the field is mapped as nodename, not nodeName. its representing $node->getName() - calling it just name seemed to confusing.

        i vote against it, but if we want to change the mapping, we should do that right now, as i am breaking everything anyways in https://github.com/doctrine/phpcr-odm/pull/279

        Show
        dbu David Buchmann added a comment - because the field is mapped as nodename, not nodeName. its representing $node->getName() - calling it just name seemed to confusing. i vote against it, but if we want to change the mapping, we should do that right now, as i am breaking everything anyways in https://github.com/doctrine/phpcr-odm/pull/279
        Hide
        dbu David Buchmann added a comment -

        ok if we close this and leave as is?

        Show
        dbu David Buchmann added a comment - ok if we close this and leave as is?
        lsmith Lukas Kahwe made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={expand=changesets[0:20].revisions[0:29],reviews, query=PHPCR-109}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            lsmith Lukas Kahwe
            Reporter:
            dantleech Daniel Leech
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: