Doctrine PHPCR
  1. Doctrine PHPCR
  2. PHPCR-109

Why Generic::getNodename and not camelcase?

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Labels:
      None

      Description

      Is there a reason why the get node name method on the generic document is ->getNodename and not ->getNodeName?

        Activity

        Hide
        David Buchmann added a comment -

        ok if we close this and leave as is?

        Show
        David Buchmann added a comment - ok if we close this and leave as is?
        Hide
        David Buchmann added a comment -

        because the field is mapped as nodename, not nodeName. its representing $node->getName() - calling it just name seemed to confusing.

        i vote against it, but if we want to change the mapping, we should do that right now, as i am breaking everything anyways in https://github.com/doctrine/phpcr-odm/pull/279

        Show
        David Buchmann added a comment - because the field is mapped as nodename, not nodeName. its representing $node->getName() - calling it just name seemed to confusing. i vote against it, but if we want to change the mapping, we should do that right now, as i am breaking everything anyways in https://github.com/doctrine/phpcr-odm/pull/279

          People

          • Assignee:
            Lukas Kahwe
            Reporter:
            Daniel Leech
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: