Doctrine PHPCR
  1. Doctrine PHPCR
  2. PHPCR-105

ensure xml and yml naming conventions are consistent

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Labels:
      None

      Description

      for yml, all mappings must use camelCase, while for xml it must be connected-text in all lowercase with the dash between. it seems at least fieldName is wrong.

      we should clean this up before the first release to avoid having to deal with inconsistent legacy from the beginning.

        Activity

        David Buchmann created issue -
        David Buchmann made changes -
        Field Original Value New Value
        Priority Critical [ 2 ] Blocker [ 1 ]
        Hide
        David Buchmann added a comment -
        Show
        David Buchmann added a comment - for xml, see this PR https://github.com/doctrine/phpcr-odm/pull/279
        Hide
        David Buchmann added a comment -

        yml is using camelCase everywhere. should we rename fieldName to name as well or is that fine here?

        Show
        David Buchmann added a comment - yml is using camelCase everywhere. should we rename fieldName to name as well or is that fine here?
        David Buchmann made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=PHPCR-105, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Lukas Kahwe
            Reporter:
            David Buchmann
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: