Doctrine MongoDB ODM

[PATCH] Allow Hydrator classes to be regenerated only if they are absent

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.0BETA2
  • Fix Version/s: 1.0.0BETA2
  • Component/s: Hydration
  • Labels:
    None

Description

Hydrator classes are either never generated ou regenerated on each request.

The patch add another case : regenerate only if absent.

HydratorFactory::$autoGenerate switches to int and can have 3 values : HydratorFactory::AUTOGENERATE_NEVER, HydratorFactory::AUTOGENERATE_ALWAYS or HydratorFactory::AUTOGENERATE_ABSENT

  1. Text File
    autogenerate.patch
    02/Feb/11 4:40 AM
    6 kB
    JF Bustarret
  2. Text File
    autogenerate.patch
    31/Jan/11 3:44 AM
    3 kB
    JF Bustarret

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jonathan H. Wage added a comment -

Hi, I don't think this is quite right. We should make this feature match the way proxies are generated. We will need to add a console command to generate the proxies for production.

Show
Jonathan H. Wage added a comment - Hi, I don't think this is quite right. We should make this feature match the way proxies are generated. We will need to add a console command to generate the proxies for production.
Hide
Permalink
JF Bustarret added a comment -

A console command would need to know the configuration of the factories... It can't be a standalone script.

A symfony script would be great (provided it works with symfony < 2), but what about non symfony users ?

I added Proxies to my patch, and switched the two const to the Configuration class.

Show
JF Bustarret added a comment - A console command would need to know the configuration of the factories... It can't be a standalone script. A symfony script would be great (provided it works with symfony < 2), but what about non symfony users ? I added Proxies to my patch, and switched the two const to the Configuration class.
Hide
Permalink
JF Bustarret added a comment - - edited

Updated patch with proxies

Show
JF Bustarret added a comment - - edited Updated patch with proxies
JF Bustarret made changes -
Field Original Value New Value
Attachment autogenerate.patch [ 10925 ]
Hide
Permalink
Jonathan H. Wage added a comment -

Hi, I added the console commands for generating proxy and hydrator clases here https://github.com/doctrine/mongodb-odm/commit/56fc267459dd0b972e710b0ff1cab5fbf1859fd9

It will be integrated with DoctrineMongoDBBundle soon.

Show
Jonathan H. Wage added a comment - Hi, I added the console commands for generating proxy and hydrator clases here https://github.com/doctrine/mongodb-odm/commit/56fc267459dd0b972e710b0ff1cab5fbf1859fd9 It will be integrated with DoctrineMongoDBBundle soon.
Jonathan H. Wage made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=MODM-112, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    JF Bustarret
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: