Doctrine Migrations

Remove implicit schema diff to sql in Migration tasks for explicit solution

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Labels:
    None

Description

Currently the following leads to an implicit drop table statement:

public function up(Schema $schema)
 {
    $schema->dropTable("foo");
}

However this should be an explicit operation that internally puts everything onto the "addSQL" stack, then resets the schema diffs to zero by cloning the current schema into the "diff schema" again.

public function up(Schema $schema)
 {
    $schema->dropTable("foo");
    $this->syncSchema($schema);
    $schema->dropTable("bar");
    $this->syncSchema($schema);
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Beau Simensen added a comment - - edited

So each call to syncSchema() would result in processing all changes on the schema instance (dropTable(), etc.) to actual SQL commands and placed on the "operations" stack? And at that point the schema instance should show no diffs so that any future calls to syncSchema() would only include schema changes since the previous call?

Show
Beau Simensen added a comment - - edited So each call to syncSchema() would result in processing all changes on the schema instance ( dropTable() , etc.) to actual SQL commands and placed on the "operations" stack? And at that point the schema instance should show no diffs so that any future calls to syncSchema() would only include schema changes since the previous call?
Hide
Permalink
Benjamin Eberlei added a comment -

Yes exactly

Show
Benjamin Eberlei added a comment - Yes exactly
Hide
Permalink
Beau Simensen added a comment -

Alright, I'll see what I can do. I have a feeling I will get a pretty good idea how everything works if I start digging into this one.

Show
Beau Simensen added a comment - Alright, I'll see what I can do. I have a feeling I will get a pretty good idea how everything works if I start digging into this one.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: