Doctrine Migrations

Drop not null is not working in Postgres

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Won't Fix
  • Labels:
    None
  • Environment:
    Postgresql 8.4, Symfony 1.4, Doctrine 1.2

Description

When removing the not null from a column the migration does not change anything in the database. This is due to the following check on line 162 of lib/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Export/Pgsql.php

if ( ! empty($field['definition']['notnull']))

So if notnull is not there or set to false or '0' or 0 the code does not enter into that if statement and therefore no changes are done to the not null value of the column.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lea Haensenberger added a comment -

I recreated the bug report in the doctrine 1 project since it rather belongs there.

Show
Lea Haensenberger added a comment - I recreated the bug report in the doctrine 1 project since it rather belongs there.
Lea Haensenberger made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Won't Fix [ 2 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DMIG-15, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Lea Haensenberger
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: