Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-946

Evaluate optional use of igbinary for serialization

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      Igbinary is supposed to be faster and better than serialize/unserialize(). We should check if its relevant for us (metadata and query caching for example):

      https://github.com/phadej/igbinary

        Activity

        Benjamin Eberlei created issue -
        Show
        Benjamin Eberlei added a comment - http://ilia.ws/archives/211-Igbinary,-The-great-serializer.html#extended
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Workflow jira [ 12246 ] jira-feedback [ 13892 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback [ 13892 ] jira-feedback2 [ 15756 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 15756 ] jira-feedback3 [ 18013 ]
        Hide
        Marco Pivetta added a comment -

        I don't think this is still relevant: closing it, since the serialization improvement can be achieved by hacking a new Doctrine\Common\Cache\Cache implementation for those who really need it.

        Show
        Marco Pivetta added a comment - I don't think this is still relevant: closing it, since the serialization improvement can be achieved by hacking a new Doctrine\Common\Cache\Cache implementation for those who really need it.
        Marco Pivetta made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Roman S. Borschel [ romanb ] Marco Pivetta [ ocramius ]
        Resolution Won't Fix [ 2 ]
        Hide
        Marco Pivetta added a comment -

        Just a note. Benjamin Eberlei told me that igbinary overrides `unserialize` breaking compat. I personally think that's a very bad idea, but it's not a problem if you use PHP 5.4, since we automatically get rid of the `unserialize` hack and use `ReflectionClass#newInstanceWithoutConstructor()` instead, which is much cleaner

        Show
        Marco Pivetta added a comment - Just a note. Benjamin Eberlei told me that igbinary overrides `unserialize` breaking compat. I personally think that's a very bad idea, but it's not a problem if you use PHP 5.4, since we automatically get rid of the `unserialize` hack and use `ReflectionClass#newInstanceWithoutConstructor()` instead, which is much cleaner

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-946, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Marco Pivetta
            Reporter:
            Benjamin Eberlei
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: