Doctrine 2 - ORM

Inheritance Discriminator mapping fails when the parent class is after a subclass alphabetically

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 2.0-BETA4
  • Fix Version/s: 2.0-RC1
  • Component/s: Mapping Drivers
  • Security Level: All
  • Labels:
    None
  • Environment:
    PHP 5.3, PDO_MYSQL

Description

If I have a class called AbstractPage, with this single table inheritance mapping linking to the folllowing classes (Page, Article, Review), then it works fine:

<discriminator-column name="discr" type="string" />
<discriminator-map>
<discriminator-mapping value="page" class="Page" />
<discriminator-mapping value="article" class="Article" />
<discriminator-mapping value="review" class="Review" />
</discriminator-map>

If however I rename the classes to the Zend framework format, within modules (Default_Model_AbstractPage, Default_Model_Page, Article_Model_Article, Article_Model_Review), then because Article is before Default, then the schema tool gets confused and throws an error - [Doctrine\DBAL\Schema\SchemaException] The table with name 'pages' already exists. Everything else is the same but the class names.

I have attached examples of this both working and nonworking with the different naming schemes. As you can see everything else is the same.

  1. File
    nonworking.rar
    09/Sep/10 11:45 PM
    3 kB
    Daniel Moore
  2. File
    working.rar
    09/Sep/10 11:45 PM
    3 kB
    Daniel Moore

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

if yo uspecify class="page" the class has to be called Page, not Default_Model_Page. You have to change the mapping to:

<discriminator-column name="discr" type="string" />
<discriminator-map>
<discriminator-mapping value="page" class="Default_Model_Page" />
<discriminator-mapping value="article" class="Default_Model_Article" />
<discriminator-mapping value="review" class="Default_Model_Review" />
</discriminator-map>

You cannot re-use the mapping for different classes, it has to be bound specifically to an exisiting class.

Show
Benjamin Eberlei added a comment - if yo uspecify class="page" the class has to be called Page, not Default_Model_Page. You have to change the mapping to: <discriminator-column name= "discr" type= "string" /> <discriminator-map> <discriminator-mapping value= "page" class= "Default_Model_Page" /> <discriminator-mapping value= "article" class= "Default_Model_Article" /> <discriminator-mapping value= "review" class= "Default_Model_Review" /> </discriminator-map> You cannot re-use the mapping for different classes, it has to be bound specifically to an exisiting class.
Hide
Permalink
Daniel Moore added a comment -

I probably wasn't being explicit enough - when I said I rename the classes I also meant that I renamed them in all of the mapping, so I've got this:

<discriminator-column name="discr" type="string" />
<discriminator-map>
<discriminator-mapping value="page" class="Default_Model_Page" />
<discriminator-mapping value="article" class="Article_Model_Article" />
<discriminator-mapping value="review" class="Article_Model_Review" />
</discriminator-map>

And I've also renamed the mapping files themselves from Page.dcm.xml to Default_Model_Page.dcm.xml and so on. Still doesn't work.

Show
Daniel Moore added a comment - I probably wasn't being explicit enough - when I said I rename the classes I also meant that I renamed them in all of the mapping, so I've got this: <discriminator-column name="discr" type="string" /> <discriminator-map> <discriminator-mapping value="page" class="Default_Model_Page" /> <discriminator-mapping value="article" class="Article_Model_Article" /> <discriminator-mapping value="review" class="Article_Model_Review" /> </discriminator-map> And I've also renamed the mapping files themselves from Page.dcm.xml to Default_Model_Page.dcm.xml and so on. Still doesn't work.
Hide
Permalink
Daniel Moore added a comment -

I've found a workaround for now. Move the subclasses into another folder (I've create a subfolder called "subclasses") and then add the second line:

$driverImpl = new Doctrine\ORM\Mapping\Driver\XmlDriver(_DIR_ . '/mappings');
$driverImpl->addPaths(array(_DIR_ . '/mappings/subclasses'));

That way the second folder will get read after the parent classes.

Show
Daniel Moore added a comment - I've found a workaround for now. Move the subclasses into another folder (I've create a subfolder called "subclasses") and then add the second line: $driverImpl = new Doctrine\ORM\Mapping\Driver\XmlDriver(_ DIR _ . '/mappings'); $driverImpl->addPaths(array(_ DIR _ . '/mappings/subclasses')); That way the second folder will get read after the parent classes.
Hide
Permalink
Benjamin Eberlei added a comment -

This issue was fixed in another ticket.

Show
Benjamin Eberlei added a comment - This issue was fixed in another ticket.
Benjamin Eberlei made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Assignee Roman S. Borschel [ romanb ] Benjamin Eberlei [ beberlei ]
Fix Version/s 2.0-RC1 [ 10091 ]
Resolution Duplicate [ 3 ]
Benjamin Eberlei made changes -
Workflow jira [ 11899 ] jira-feedback [ 14573 ]
Benjamin Eberlei made changes -
Workflow jira-feedback [ 14573 ] jira-feedback2 [ 16437 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 16437 ] jira-feedback3 [ 18690 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-796, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Daniel Moore
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: