Doctrine 2 - ORM

Generating entities with cli failed on inheritated entities due missing PK

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-BETA4
  • Fix Version/s: 2.0-BETA4
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None
  • Environment:
    Kubuntu lucid lynx

Description

While generating entities with:

./doctrine orm:generate-entities --generate-methods=true ../tmp/entities

getting MappingException: No identifier/primary key specified for Entity 'Entities\Admin'. Every Entity must have an identifier/primary key.

Admin is class inheritated, definition included:

Person: http://pastebin.com/5r9fXrAu
Admin: http://pastebin.com/51BcRZWZ

Activity

Ascending order - Click to sort in descending order
Eduard Kracmar made changes -
Field Original Value New Value
Description While generating entities with:

./doctrine orm:generate-entities --generate-methods=true ../tmp/entities

getting MappingException: No identifier/primary key specified for Entity 'Entities\Admin'. Every Entity must have an identifier/primary key.

Admin is class inheritated, definition included:


/**
 * Admin
 * @author kraken
 */

/**
 * @entity
 * @table(name="admins")
 */
class Admin extends Person {
    /**
     * Addons
     */
    /**
     * Events
     */
    /**
     * Getters and setters
     */
}



/**
 * Person
 * @author kraken
 */

/**
 * @entity
 * @inheritanceType("JOINED")
 * @discriminatorColumn(name="role_discr", type="string")
 * @discriminatorMap({"Developer" = "Entities\Developer", "Superadmin" = "Entities\Superadmin", "Admin" = "Entities\Admin", "Installer" = "Entities\Installer", "User" = "Entities\User"})
 * @table(name="persons")
 * @hasLifecycleCallbacks
 * @abstract
 */
abstract class Person extends \DannaxTools\BaseEntity {

    /**
     * @id
     * @column(type="integer")
     * @generatedValue(strategy="SEQUENCE")
     */
    private $id;
    /**
     * @ManyToOne(targetEntity="Person")
     * @JoinColumn(name="id_creator", referencedColumnName="id", nullable=true)
     */
    private $creator;
    /**
     * @ManyToOne(targetEntity="Role")
     * @JoinColumn(name="id_role", referencedColumnName="id", nullable=false)
     */
    private $role;
    /**
     * @column(type="string", length=200, nullable=false, unique=true)
     */
    private $email;
    /**
     * @column(type="string", length=200, nullable=false)
     */
    private $firstName;
    /**
     * @column(type="string", length=200, nullable=false)
     */
    private $password;
    /**
     * @column(type="string", length=200, nullable=false)
     */
    private $lastName;
    /**
     * @column(type="boolean", nullable=false)
     */
    private $active;
    /**
     * @column(type="datetime", nullable=false)
     */
    private $modified;
    /**
     * @column(type="datetime", nullable=false)
     */
    private $created;



 While generating entities with:

./doctrine orm:generate-entities --generate-methods=true ../tmp/entities

getting MappingException: No identifier/primary key specified for Entity 'Entities\Admin'. Every Entity must have an identifier/primary key.

Admin is class inheritated, definition included:

Person: http://pastebin.com/5r9fXrAu
Admin: http://pastebin.com/51BcRZWZ
Hide
Permalink
Benjamin Eberlei added a comment -

You cannot generate entities in an inheritance hierachy currently

Show
Benjamin Eberlei added a comment - You cannot generate entities in an inheritance hierachy currently
Hide
Permalink
Benjamin Eberlei added a comment -

AFter having looked at the mappings, how do you plan to generate methods from annotated entities? I think the entity generator won't allow that, jwage?

Show
Benjamin Eberlei added a comment - AFter having looked at the mappings, how do you plan to generate methods from annotated entities? I think the entity generator won't allow that, jwage?
Benjamin Eberlei made changes -
Assignee Roman S. Borschel [ romanb ] Jonathan H. Wage [ jwage ]
Hide
Permalink
Jonathan H. Wage added a comment -

The problem with everything is that the inheritance hierarchy is not mapped, instead it is read at runtime from the classes themselves. So, when you're generating the initial entities from the mapping information, you don't have that information, so we can't properly generate a class with the "class ClassName extends SomeOtherClass" because we simply don't know it.

To work around it all you have to do is manually create the file with the empty class inside of it, extending the class you want. When you run the orm:generate-entities again, it can properly read the subclasses of every entity and the generation will update the classes existing classes properties and methods instead of trying to generate a new class.

Does that clear things up? I think the only way to fix it would be to allow the user to manually specify the all the inheritance information in the mapping information instead of reading it at run-time. That way we have all the information about some entities even before the actual classes exist and we can generate the right code then.

Thoughts?

Show
Jonathan H. Wage added a comment - The problem with everything is that the inheritance hierarchy is not mapped, instead it is read at runtime from the classes themselves. So, when you're generating the initial entities from the mapping information, you don't have that information, so we can't properly generate a class with the "class ClassName extends SomeOtherClass" because we simply don't know it. To work around it all you have to do is manually create the file with the empty class inside of it, extending the class you want. When you run the orm:generate-entities again, it can properly read the subclasses of every entity and the generation will update the classes existing classes properties and methods instead of trying to generate a new class. Does that clear things up? I think the only way to fix it would be to allow the user to manually specify the all the inheritance information in the mapping information instead of reading it at run-time. That way we have all the information about some entities even before the actual classes exist and we can generate the right code then. Thoughts?
Hide
Permalink
Jonathan H. Wage added a comment -

Benjamin, yes it is possible. But like I mentioned above we don't know what class an entity extends until the class is created. You have no way to say in the mapping information that this entity extends this class.

If you have an entity already created with just the annotated properties, and you run the command to generate entities it will update the class adding the methods to the class. If you were to add a new property to the class and annotate and run the command again, it would only add the 2 new methods to the bottom of the class.

Show
Jonathan H. Wage added a comment - Benjamin, yes it is possible. But like I mentioned above we don't know what class an entity extends until the class is created. You have no way to say in the mapping information that this entity extends this class. If you have an entity already created with just the annotated properties, and you run the command to generate entities it will update the class adding the methods to the class. If you were to add a new property to the class and annotate and run the command again, it would only add the 2 new methods to the bottom of the class.
Jonathan H. Wage made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Eduard Kracmar added a comment -

This is really what I'm looking for. I create classes, fill them with properties and define annotations for them. Then I run cli tool to generate all methods (getters and setters) for classes to skip the boring part of creating entity. Then if required, I modify getters and setters.

Only problem was that it failed on classes that were inheritated because they were missing primary keys.

As a workaround while generating methods for new entities, I moved away from project inheritated entities and after generating I moved them back.

Show
Eduard Kracmar added a comment - This is really what I'm looking for. I create classes, fill them with properties and define annotations for them. Then I run cli tool to generate all methods (getters and setters) for classes to skip the boring part of creating entity. Then if required, I modify getters and setters. Only problem was that it failed on classes that were inheritated because they were missing primary keys. As a workaround while generating methods for new entities, I moved away from project inheritated entities and after generating I moved them back.
Benjamin Eberlei made changes -
Workflow jira [ 11886 ] jira-feedback [ 14568 ]
Benjamin Eberlei made changes -
Workflow jira-feedback [ 14568 ] jira-feedback2 [ 16432 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 16432 ] jira-feedback3 [ 18685 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-790, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Jonathan H. Wage
    Reporter:
    Eduard Kracmar
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: