Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-758

When merging many to many entites back into the repository changes to the associations are not respected

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0-RC1
    • Component/s: ORM
    • Security Level: All
    • Labels:
      None

      Description

      When merging a DETACHED entity into the repository with ManyToMany associations that have changed since the last flush, the join table is not updated with the new associations.

      Many Movies have many Artists with cascade merge:

      class Movie {
      	
      	/** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
      	public $id;
      	
      	/** @Column(length=50, type="string") */
      	public $title;
      	
      	/** 
      	 * @ManyToMany(targetEntity="Artist", cascade={"merge"})
      	 */
      	public $artists;
      	
      	public function __construct() {
      		$this->artists = new ArrayCollection();
      	}	
      
      }
      
      <?php
      class Artist {
      	
      	/** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
      	public $id;
      	
      	/** @Column(length=50, type="string") */
      	public $name;
      	
      	/** @ManyToMany(targetEntity="Movie", mappedBy="artists", cascade={"merge"}) */
      	public $movies;
      	
      	public function __construct() {
      		$this->movies = new ArrayCollection();
      	}
      	
      }
      

      Assume that the database contains:
      Movie: id=1, title="Movie 1"
      Artist: id=1, name="Artist 1"
      Artist: id=2, name="Artist 2"

      and that there is a entry (1, 1) in movie_artist so that there is a many-many relationship between Movie 1 and Artist 1.

      I now want to merge a detched version of a movie into the repository, with an extra relationship between Movie 1 and Artist 2:

      $m1 = new \vo\Movie();
      $m1->id = 1;
      $m1->title = "Movie 1";
      
      $a1 = new \vo\Artist();
      $a1->id = 1;
      $a1->name = "Artist 1";
      
      $a2 = new \vo\Artist();
      $a2->id = 2;
      $a2->name = "Artist 2";
      
      $m1->artists->add($a1); $a1->movies->add($m1);
      
      // Add the new association
      $m1->artists->add($a2); $a2->movies->add($m1);
      
      // This is a cascade merge so it will merge the entities down the tree
      $m1 = $em->merge($m1);
      

      At this point $m1 should contains merged entities reflecting the same as what is in the database, plus the extra association between Movie 1 and Artist 2, so after a flush() movie_artist should contain (1,1),(1,2)

      I now run:

      $em->flush();
      

      but movie_artist remains unchanged (still just (1,1)) and $em->getUnitOfWork()->computeChangeSets() is empty before the flush().

      The same behaviour is exhibited when merging $m1 after deleting entities from its many-to-many associations; movie_artist does not change.

      1. 0147-DDC-758.patch
        2 kB
        Dave Keen
      2. DDC758Test.php
        6 kB
        Dave Keen

        Activity

        Dave Keen created issue -
        Dave Keen made changes -
        Field Original Value New Value
        Description When merging a DETACHED entity into the repository with a ManyToMany associations that have changed since the last flush, the join table is not updated with the new associations.

        Many Movies have many Artists with cascade merge:

        {code}
        class Movie {

        /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
        public $id;

        /** @Column(length=50, type="string") */
        public $title;

        /**
        * @ManyToMany(targetEntity="Artist", cascade={"merge"})
        */
        public $artists;

        public function __construct() {
        $this->artists = new ArrayCollection();
        }

        }
        {code}

        {code}
        <?php
        class Artist {

        /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
        public $id;

        /** @Column(length=50, type="string") */
        public $name;

        /** @ManyToMany(targetEntity="Movie", mappedBy="artists", cascade={"merge"}) */
        public $movies;

        public function __construct() {
        $this->movies = new ArrayCollection();
        }

        }
        {code}

        Assume that the database contains:
        Movie: id=1, title="Movie 1"
        Artist: id=1, name="Artist 1"
        Artist: id=2, name="Artist 2"

        and that there is a entry (1, 1) in movie_artist so that there is a many-many relationship between Movie 1 and Artist 1.

        I now want to merge a detched version of a movie into the repository, with an extra relationship between Movie 1 and Artist 2:

        {code}
        $m1 = new \vo\Movie();
        $m1->id = 1;
        $m1->title = "Movie 1";

        $a1 = new \vo\Artist();
        $a1->id = 1;
        $a1->name = "Artist 1";

        $a2 = new \vo\Artist();
        $a2->id = 2;
        $a2->name = "Artist 2";

        $m1->artists->add($a1); $a1->movies->add($m1);

        // Add the new association
        $m1->artists->add($a2); $a1->movies->add($m1);

        // This is a cascade merge so it will merge the entities down the tree
        $m1 = $em->merge($m1);
        {code}

        At this point $m1 should contains merged entities reflecting the same as what is in the database, plus the extra association between Movie 1 and Artist 2, so after a flush() movie_artist should contain (1,1),(1,2)

        I now run:

        {code}
        $em->flush();
        {code}

        but movie_artist remains unchanged (still just (1,1)) and $em->getUnitOfWork()->computeChangeSets() is empty before the flush().

        The same behaviour is exhibited when merging $m1 after deleting entities from its many-to-many associations; movie_artist does not change.
        When merging a DETACHED entity into the repository with ManyToMany associations that have changed since the last flush, the join table is not updated with the new associations.

        Many Movies have many Artists with cascade merge:

        {code}
        class Movie {

        /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
        public $id;

        /** @Column(length=50, type="string") */
        public $title;

        /**
        * @ManyToMany(targetEntity="Artist", cascade={"merge"})
        */
        public $artists;

        public function __construct() {
        $this->artists = new ArrayCollection();
        }

        }
        {code}

        {code}
        <?php
        class Artist {

        /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
        public $id;

        /** @Column(length=50, type="string") */
        public $name;

        /** @ManyToMany(targetEntity="Movie", mappedBy="artists", cascade={"merge"}) */
        public $movies;

        public function __construct() {
        $this->movies = new ArrayCollection();
        }

        }
        {code}

        Assume that the database contains:
        Movie: id=1, title="Movie 1"
        Artist: id=1, name="Artist 1"
        Artist: id=2, name="Artist 2"

        and that there is a entry (1, 1) in movie_artist so that there is a many-many relationship between Movie 1 and Artist 1.

        I now want to merge a detched version of a movie into the repository, with an extra relationship between Movie 1 and Artist 2:

        {code}
        $m1 = new \vo\Movie();
        $m1->id = 1;
        $m1->title = "Movie 1";

        $a1 = new \vo\Artist();
        $a1->id = 1;
        $a1->name = "Artist 1";

        $a2 = new \vo\Artist();
        $a2->id = 2;
        $a2->name = "Artist 2";

        $m1->artists->add($a1); $a1->movies->add($m1);

        // Add the new association
        $m1->artists->add($a2); $a2->movies->add($m1);

        // This is a cascade merge so it will merge the entities down the tree
        $m1 = $em->merge($m1);
        {code}

        At this point $m1 should contains merged entities reflecting the same as what is in the database, plus the extra association between Movie 1 and Artist 2, so after a flush() movie_artist should contain (1,1),(1,2)

        I now run:

        {code}
        $em->flush();
        {code}

        but movie_artist remains unchanged (still just (1,1)) and $em->getUnitOfWork()->computeChangeSets() is empty before the flush().

        The same behaviour is exhibited when merging $m1 after deleting entities from its many-to-many associations; movie_artist does not change.
        Roman S. Borschel made changes -
        Fix Version/s 2.0-RC1 [ 10091 ]
        Dave Keen made changes -
        Attachment DDC758Test.php [ 10792 ]
        Dave Keen made changes -
        Attachment DDC758Test.php [ 10792 ]
        Dave Keen made changes -
        Attachment DDC758Test.php [ 10794 ]
        Dave Keen made changes -
        Attachment DDC758Test.php [ 10794 ]
        Dave Keen made changes -
        Attachment DDC758Test.php [ 10807 ]
        Dave Keen made changes -
        Attachment 0147-DDC-758.patch [ 10808 ]
        Dave Keen made changes -
        Attachment 0147-DDC-758.patch [ 10808 ]
        Dave Keen made changes -
        Comment [ This is an attempted patch to the issue. After each cascade merges this fills in $snapshot from the database. ]
        Dave Keen made changes -
        Attachment 0147-DDC-758.patch [ 10809 ]
        Dave Keen made changes -
        Attachment 0147-DDC-758.patch [ 10809 ]
        Dave Keen made changes -
        Attachment 0147-DDC-758.patch [ 10810 ]
        Benjamin Eberlei made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Roman S. Borschel [ romanb ] Benjamin Eberlei [ beberlei ]
        Resolution Fixed [ 1 ]
        Benjamin Eberlei made changes -
        Workflow jira [ 11802 ] jira-feedback [ 14544 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback [ 14544 ] jira-feedback2 [ 16408 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 16408 ] jira-feedback3 [ 18661 ]

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Dave Keen
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: