Doctrine 2 - ORM

Nasty ordering issue with fetch-joins

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0-BETA3
  • Fix Version/s: 2.0-RC1
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

Will not work correctly:

select c, ca from Cart ca join ca.customer c

Works correctly:

select ca, c from Cart ca join ca.customer c

In the first case the ordering of the DQL aliases causes associations to be skipped during hydration.

  1. Text File
    ddc736.patch
    10/Nov/10 5:36 PM
    4 kB
    Benjamin Eberlei
  2. Text File
    ddc736-simplified.patch
    12/Nov/10 5:56 PM
    4 kB
    Roman S. Borschel
  3. File
    DDC736Test.php
    06/Nov/10 1:13 PM
    1 kB
    Roman S. Borschel

Issue Links

is referenced by

Bug - A problem which impairs or prevents the functions of the product. DDC-915 Breaks with Fixing Identification Variables and SQL Walkers

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Bug - A problem which impairs or prevents the functions of the product. DDC-925 Breaks with Fixing Identification Variables and SQL Walkers - 2

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Descending order - Click to sort in ascending order
Hide
Permalink
Mikko Hirvonen added a comment -

I think that this patch breaks modifying the select clause in custom tree walkers because walking the select clause will be done after the $_identVariableExpressions array is populated. Reordering the identification variables will then override the modified select clause.

Show
Mikko Hirvonen added a comment - I think that this patch breaks modifying the select clause in custom tree walkers because walking the select clause will be done after the $_identVariableExpressions array is populated. Reordering the identification variables will then override the modified select clause.
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed.

Show
Benjamin Eberlei added a comment - Fixed.
Hide
Permalink
Roman S. Borschel added a comment -

Attached simplified patch.

Show
Roman S. Borschel added a comment - Attached simplified patch.
Hide
Permalink
Benjamin Eberlei added a comment -

Patch that solves this problem. What does it do?

Two additional instance variables are needed, one for the order of the AliasIdentificationVariables and one for a IdentVariable => SelectExpression lookup map.

Inside parse() a reordering is done right before the SQL Walkers are created. This is only done if there is more than one Identification variable in the select expressions, otherwise its not necessary.

The reordering iterates in order of the alias identification variables, grabs the expression from the select expressions and appends it to them. This way it is guaranteed that the expressions are ordered correctly.

SELECT a, b, c.foo, count(d.bar) FROM B b JOIN b.a a JOIN ...

becomes:

SELECT c.foo, count(d.bar), b, a FROM ...

Roman do you think this is viable? See the patch for more details

Show
Benjamin Eberlei added a comment - Patch that solves this problem. What does it do? Two additional instance variables are needed, one for the order of the AliasIdentificationVariables and one for a IdentVariable => SelectExpression lookup map. Inside parse() a reordering is done right before the SQL Walkers are created. This is only done if there is more than one Identification variable in the select expressions, otherwise its not necessary. The reordering iterates in order of the alias identification variables, grabs the expression from the select expressions and appends it to them. This way it is guaranteed that the expressions are ordered correctly. SELECT a, b, c.foo, count(d.bar) FROM B b JOIN b.a a JOIN ... becomes: SELECT c.foo, count(d.bar), b, a FROM ... Roman do you think this is viable? See the patch for more details
Hide
Permalink
Tim Oram added a comment -

If anyone is getting issues with missing or incorrectly ordered relations it may be caused by this bug.

Would it be possible to put a note in the documentation to ensure the order of the select clause must match that of the joins. I just spent 2 days trying to figure out why the data being returned was incorrect.

Show
Tim Oram added a comment - If anyone is getting issues with missing or incorrectly ordered relations it may be caused by this bug. Would it be possible to put a note in the documentation to ensure the order of the select clause must match that of the joins. I just spent 2 days trying to figure out why the data being returned was incorrect.
Hide
Permalink
Roman S. Borschel added a comment -

Scheduling for RC1.

Show
Roman S. Borschel added a comment - Scheduling for RC1.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Roman S. Borschel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: