Proxy autogeneration fails with concurrent requests

The following fixes it on Linux, but I think will not work in Windows (iirc, rename() on Windows won't work if the dest file already exists, much less atomically):

--- Proxy/ProxyFactory.php	(revision 2)
+++ Proxy/ProxyFactory.php	(working copy)
@@ -144,7 +144,9 @@
 
         $file = str_replace($placeholders, $replacements, $file);
 
-        file_put_contents($fileName, $file);
+        $tmpFileName = $fileName.'-'.uniqid('', true);;
+        file_put_contents($tmpFileName, $file);
+        rename($tmpFileName, $fileName);
     }
 
     /**

I don't even know why this is needed. Can't the file just be returned as string and eval()'d, instead of being written to a file and then require()'d?

we should just change file_put_Contents into:

file_put_contents($fileName, $file, LOCK_EX);

Setting the LOCK_EX constant now, this should solve the issue.

However in high concurrency scenarios the "autoGenerateProxyClasses" flag should always be FALSE and the proxies be generated during build-time.

LOCK_EX doesn't fix it for me. Apparently it's still possible that the file doesn't exist:

E_WARNING (2): include(MyProxies/MyClassProxy.php) [<a href='function.include'>function.include</a>]: failed to open stream: No such file or directory

Please note that my above uniqid+rename suggestion only works if more_entropy is true, if you decide to add it.

However, I'd much prefer having an option of just not using these files at all. I've created an Improvement ticket DDC-717 for this.

i now underestand what you are doing wrong.

if you set autogenerate = false you have to call doctrine orm:generate-proxies

I'm not setting it to false!

> When doing concurrent requests with autogeneration of proxies enabled

ah ok, eval is just a workaround.

Closed again, See DDC-717 for a timetable of a fix using auto-generate = true in production.