Doctrine 2 - ORM

Inheritance-type with no discriminator-column results in SQL Error

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0-BETA2
  • Fix Version/s: 2.0-BETA4
  • Component/s: Mapping Drivers
  • Security Level: All
  • Labels:
    None
  • Environment:
    PHP 5.3 Ubuntu Linux

Description

On an entity (XML mapping atleast) if there is an inheritance-type set but no discriminator-column(s) set the resulting query will have an extra comma at the end of the field list or occasionally (based on inheritance-type) a table alias without a fieldname.

The correct solution would be to throw an exception during the parsing of the mapping that would indicate the inheritance-type is set but no discriminator-columns exist.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Mealey added a comment -

Moving this from Major to Minor as a correctly mapped entity works fine, the bug is in the error reporting, not the functionality

Show
Chris Mealey added a comment - Moving this from Major to Minor as a correctly mapped entity works fine, the bug is in the error reporting, not the functionality
Hide
Permalink
Benjamin Eberlei added a comment -

Implemented better validation

Show
Benjamin Eberlei added a comment - Implemented better validation
Hide
Permalink
Michael Ridgway added a comment - - edited

I can't help but feel that the validation should be implemented outside of the metadata drivers. To me the driver shouldn't require the discriminator map to be present because it limits the ability to add discriminators in other ways.

Example:

I use annotations for my models, but I don't set the discriminator maps using the annotations driver, instead I use the loadClassMetadata event to fill in the discriminatorMap from configs or a database. Perhaps this is a job for a custom metadata driver, but I still can't help but feel that the metadata driver shouldn't be the one making these validations, it should be when you try to use the inheritance-mapped model.

Edit: To clarify the situation: I now get mappingException::missingDiscriminatorMap exception because my model annotations don't have a @DiscriminatorMap, but they would be loaded with the loadClassMetadata function.

Show
Michael Ridgway added a comment - - edited I can't help but feel that the validation should be implemented outside of the metadata drivers. To me the driver shouldn't require the discriminator map to be present because it limits the ability to add discriminators in other ways. Example: I use annotations for my models, but I don't set the discriminator maps using the annotations driver, instead I use the loadClassMetadata event to fill in the discriminatorMap from configs or a database. Perhaps this is a job for a custom metadata driver, but I still can't help but feel that the metadata driver shouldn't be the one making these validations, it should be when you try to use the inheritance-mapped model. Edit: To clarify the situation: I now get mappingException::missingDiscriminatorMap exception because my model annotations don't have a @DiscriminatorMap, but they would be loaded with the loadClassMetadata function.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Chris Mealey
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: