Doctrine Project

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Doctrine 2 - ORM
  • Doctrine 2 - ORM
  • DDC-684

Flaw in Build Process?

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-BETA4
  • Component/s: Tools
  • Security Level: All
  • Labels:
    None

Description

As I see it from our build script, each PEAR package of ORM and DBAL includes the Common sources again, although it sets itself as dependent on that package? That would mean the ORM package overwrites the files from the DBAL and Common packages.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • History
  • Activity
  • Source
Hide
Permalink
Benjamin Eberlei added a comment - 07/Aug/10 5:40 AM

Assigned to jon.

One solution would be to change the package.xml to reference only the ORM code, although DBAL and Common are also shipped.

Show
Benjamin Eberlei added a comment - 07/Aug/10 5:40 AM Assigned to jon. One solution would be to change the package.xml to reference only the ORM code, although DBAL and Common are also shipped.
Hide
Permalink
Jonathan H. Wage added a comment - 07/Aug/10 8:46 AM

Hmm. I don't understand what you mean. The ORM includes the DBAL and Common code and installs it? Should it not do that and require that you install the dependencies via PEAR?

Show
Jonathan H. Wage added a comment - 07/Aug/10 8:46 AM Hmm. I don't understand what you mean. The ORM includes the DBAL and Common code and installs it? Should it not do that and require that you install the dependencies via PEAR?
Hide
Permalink
Benjamin Eberlei added a comment - 07/Aug/10 10:02 AM

yes, otherwise if you install DBAL after ORM, the DBAL code will overwrite the DBAL code from the ORM. Or the other way around.

Plus if you deinstall DBAL it will deinstall the DBAL code although ORM might still be installed.

I can come up with about 20 other scenarios where this is problematic

Show
Benjamin Eberlei added a comment - 07/Aug/10 10:02 AM yes, otherwise if you install DBAL after ORM, the DBAL code will overwrite the DBAL code from the ORM. Or the other way around. Plus if you deinstall DBAL it will deinstall the DBAL code although ORM might still be installed. I can come up with about 20 other scenarios where this is problematic
Hide
Permalink
Roman S. Borschel added a comment - 30/Aug/10 6:21 AM

Can we address this for BETA4 or should we push that to RC1 ? After releasing beta4 we still have time to address a lot of things before we go into RC.

Show
Roman S. Borschel added a comment - 30/Aug/10 6:21 AM Can we address this for BETA4 or should we push that to RC1 ? After releasing beta4 we still have time to address a lot of things before we go into RC.
Hide
Permalink
Jonathan H. Wage added a comment - 30/Aug/10 10:27 AM

I think the only solution is for the pear packages to only include the specific code for that package and the dependencies installed via pear. But even then, installing the ORM will require a certain version of the DBAL, so if you already have a version of the DBAL installed, it will need you to install the version the ORM requires. So either way you can't mix and match packages. If you use the ORM, you wouldn't ever have your own version of Common and DBAL installed because they would conflict.

Show
Jonathan H. Wage added a comment - 30/Aug/10 10:27 AM I think the only solution is for the pear packages to only include the specific code for that package and the dependencies installed via pear. But even then, installing the ORM will require a certain version of the DBAL, so if you already have a version of the DBAL installed, it will need you to install the version the ORM requires. So either way you can't mix and match packages. If you use the ORM, you wouldn't ever have your own version of Common and DBAL installed because they would conflict.
Hide
Permalink
Benjamin Eberlei added a comment - 30/Aug/10 11:48 AM

yes, but that is a downside of PEAR that we cannot influence.

Show
Benjamin Eberlei added a comment - 30/Aug/10 11:48 AM yes, but that is a downside of PEAR that we cannot influence.
Hide
Permalink
Jonathan H. Wage added a comment - 30/Aug/10 12:54 PM

So the same problem exists either way. Do we have anything to fix then?

Show
Jonathan H. Wage added a comment - 30/Aug/10 12:54 PM So the same problem exists either way. Do we have anything to fix then?
Hide
Permalink
Benjamin Eberlei added a comment - 30/Aug/10 5:39 PM

Fixed:

http://github.com/doctrine/dbal/commit/8054984a0448c54d5c658f60707b9ac490425c8b
http://github.com/doctrine/doctrine2/commit/803e33836518b7c019db667f482601f55803c29d

2 packages are now generated, one full package and one PEAR package. The PEAR package does not contain its dependencies, instead defines where to fetch them using the <dependencies><package> configuration for d51PearPkg2 task.

Show
Benjamin Eberlei added a comment - 30/Aug/10 5:39 PM Fixed: http://github.com/doctrine/dbal/commit/8054984a0448c54d5c658f60707b9ac490425c8b http://github.com/doctrine/doctrine2/commit/803e33836518b7c019db667f482601f55803c29d 2 packages are now generated, one full package and one PEAR package. The PEAR package does not contain its dependencies, instead defines where to fetch them using the <dependencies><package> configuration for d51PearPkg2 task.

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (0)

Dates

  • Created:
    11/Jul/10 3:53 AM
    Updated:
    30/Aug/10 5:39 PM
    Resolved:
    30/Aug/10 5:39 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Doctrine Project. Try JIRA - bug tracking software for your team.