Doctrine 2 - ORM

EntityManager#lock() on unitialized proxy coudl be optimized

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0-BETA2
  • Fix Version/s: None
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

If you call lock() on an unitiialized proxy, it would be possible to combine the fetch and lock in one operation. Is this feasible from a technical / workflow perspsective?

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. DDC-681 PATCH: UnitOfWork#lock locks by column names instead of field names

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Hide
Permalink
Benjamin Eberlei added a comment -

Ok this is what refresh() with LOCK support is actually needed for:

    public function lock($entity, $lockMode, $lockVersion = null)
    {
        if ($this->getEntityState($entity) != self::STATE_MANAGED) {
            throw new InvalidArgumentException("Entity is not MANAGED.");
        } else if ($entity instanceof Proxy && $entity->__isInitialized__) {
            $this->refresh(....); // with LOCK!
        }
        ...
    }
Show
Benjamin Eberlei added a comment - Ok this is what refresh() with LOCK support is actually needed for: public function lock($entity, $lockMode, $lockVersion = null ) { if ($ this ->getEntityState($entity) != self::STATE_MANAGED) { throw new InvalidArgumentException( "Entity is not MANAGED." ); } else if ($entity instanceof Proxy && $entity->__isInitialized__) { $ this ->refresh(....); // with LOCK! } ... }

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: