Doctrine 2 - ORM

fetch="EAGER" is not loading one to one associations

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-BETA4
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

<?php
namespace vo;

/**
 * @Entity
 */

class Appointment {
	
    /** @Id @Column(type="integer") @GeneratedValue(strategy="IDENTITY") */
    public $id;
	
	/**
     * @OneToOne(targetEntity="Patient", inversedBy="appointment", fetch="EAGER")
	 * @JoinColumn(name="patient_id", referencedColumnName="id")
     */
	public $patient;
	
}

When doing a findAll() on appointments, $patient is being created as a proxy even though fetch is EAGER.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

Fixed in master

Show
Benjamin Eberlei added a comment - Fixed in master
Hide
Permalink
Michael Moravec added a comment -

What is an advantage of this solution (in master) if it is loaded in the same way as when fetched lazily? Maybe it'd be better to use INNER JOIN instead, at least for OneToOne and save one or more (probably unnecessary) SQL queries?

Show
Michael Moravec added a comment - What is an advantage of this solution (in master) if it is loaded in the same way as when fetched lazily? Maybe it'd be better to use INNER JOIN instead, at least for OneToOne and save one or more (probably unnecessary) SQL queries?
Hide
Permalink
Benjamin Eberlei added a comment -

There is none (yet), it may be a future enhancement, however we dont know this yet. fetch=EAGER is not so useful at the moment.

Show
Benjamin Eberlei added a comment - There is none (yet), it may be a future enhancement, however we dont know this yet. fetch=EAGER is not so useful at the moment.
Hide
Permalink
Michael Moravec added a comment -

I think that fetch=EAGER should behave like this DQL:
SELECT a, b FROM foo a JOIN a.bar b
This query will use INNER JOIN to load "a.bar" association, but fetch=EAGER won't.

Should I open a new issue for this?

Show
Michael Moravec added a comment - I think that fetch=EAGER should behave like this DQL: SELECT a, b FROM foo a JOIN a.bar b This query will use INNER JOIN to load "a.bar" association, but fetch=EAGER won't. Should I open a new issue for this?
Hide
Permalink
Eduard Kracmar added a comment - - edited

fetch=EAGER still is not working as I think it should.

class Project {

/**

  • @id
  • @column(type="integer")
  • @generatedValue(strategy="SEQUENCE")
    */
    private $id;
    /**
  • @manyToOne(targetEntity="Client", inversedBy="projects", fetch="EAGER")
  • @joinColumn(name="id_client", referencedColumnName="id",nullable=false, onDelete="cascade")
    */
    private $client;

but after

$this->getEntityManager()>find('\Entities\Project', $this>project);

2 doctrine queries are executed:

SELECT t0.id AS id1, t0.name AS name2, t0.paths AS paths3, t0.modified AS modified4, t0.created AS
created5, t0.has_running_tasks AS has_running_tasks6, t0.tasksCount AS taskscount7, t0.productsCount
AS productscount8, t0.id_client AS id_client9
FROM projects t0
WHERE t0.id = ?

SELECT t0.id AS id1, t0.name AS name2, t0.modified AS modified3, t0.created AS created4
FROM clients t0
WHERE t0.id = ?

And it should be one query with inner join to clients.

Show
Eduard Kracmar added a comment - - edited fetch=EAGER still is not working as I think it should. class Project { /** @id @column(type="integer") @generatedValue(strategy="SEQUENCE") */ private $id; /** @manyToOne(targetEntity="Client", inversedBy="projects", fetch="EAGER") @joinColumn(name="id_client", referencedColumnName="id",nullable=false, onDelete="cascade") */ private $client; but after $this->getEntityManager() >find('\Entities\Project', $this >project); 2 doctrine queries are executed: SELECT t0.id AS id1, t0.name AS name2, t0.paths AS paths3, t0.modified AS modified4, t0.created AS created5, t0.has_running_tasks AS has_running_tasks6, t0.tasksCount AS taskscount7, t0.productsCount AS productscount8, t0.id_client AS id_client9 FROM projects t0 WHERE t0.id = ? SELECT t0.id AS id1, t0.name AS name2, t0.modified AS modified3, t0.created AS created4 FROM clients t0 WHERE t0.id = ? And it should be one query with inner join to clients.
Hide
Permalink
Benjamin Eberlei added a comment -

Eager doesnt mean it does a Join, it only means the query is executed directly

Show
Benjamin Eberlei added a comment - Eager doesnt mean it does a Join, it only means the query is executed directly
Hide
Permalink
Eduard Kracmar added a comment -

I see. And how can be achieved that product and client will be queried at once, and not only when I request product->getClient() ?

Show
Eduard Kracmar added a comment - I see. And how can be achieved that product and client will be queried at once, and not only when I request product->getClient() ?

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Dave Keen
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: