Details

    • Type: Documentation Documentation
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.x
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      We need a new coding standards document for Doctrine 2.

        Activity

        Roman S. Borschel created issue -
        Roman S. Borschel made changes -
        Field Original Value New Value
        Fix Version/s 2.0 [ 10021 ]
        Roman S. Borschel made changes -
        Assignee Roman S. Borschel [ romanb ] Jonathan H. Wage [ jwage ]
        Benjamin Eberlei made changes -
        Workflow jira [ 11353 ] jira-feedback [ 13850 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback [ 13850 ] jira-feedback2 [ 15714 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 15714 ] jira-feedback3 [ 17971 ]
        Hide
        Benjamin Morel added a comment -

        Has there been any work on a coding standards document yet?
        I'm currently working on fixing documentation on this project, and it might be a good time to define a standard.
        I've started compiling a few recommendations based on various feedbacks I've got in my pull requests, and I can post them here.
        Please let me know if there have been previous attempts so far!

        Show
        Benjamin Morel added a comment - Has there been any work on a coding standards document yet? I'm currently working on fixing documentation on this project, and it might be a good time to define a standard. I've started compiling a few recommendations based on various feedbacks I've got in my pull requests, and I can post them here. Please let me know if there have been previous attempts so far!
        Hide
        Marco Pivetta added a comment -

        Benjamin Morel Guilherme Blanco may have a CS ruleset, but it's not ready yet. Perfect timing btw, we really need to automate this to avoid having all these useless CS fix comments in pull requests

        Show
        Marco Pivetta added a comment - Benjamin Morel Guilherme Blanco may have a CS ruleset, but it's not ready yet. Perfect timing btw, we really need to automate this to avoid having all these useless CS fix comments in pull requests
        Hide
        Benjamin Morel added a comment - - edited

        Ok, I'll post my document here once ready, and Guilherme Blanco will be able to compare it with his ruleset!

        Show
        Benjamin Morel added a comment - - edited Ok, I'll post my document here once ready, and Guilherme Blanco will be able to compare it with his ruleset!
        Hide
        Benjamin Morel added a comment -

        Here is a first draft: https://gist.github.com/4676670

        Please comment!

        Show
        Benjamin Morel added a comment - Here is a first draft: https://gist.github.com/4676670 Please comment!
        Hide
        Benjamin Morel added a comment - - edited

        Guilherme Blanco, if you don't have time to compare your ruleset with my draft, maybe you could publish your current ruleset so that others can have a look?

        Show
        Benjamin Morel added a comment - - edited Guilherme Blanco , if you don't have time to compare your ruleset with my draft, maybe you could publish your current ruleset so that others can have a look?
        Hide
        Benjamin Morel added a comment -

        Any update guys? I'm willing to spend some time on this work, but if no one answers, we won't be going forward

        Show
        Benjamin Morel added a comment - Any update guys? I'm willing to spend some time on this work, but if no one answers, we won't be going forward
        Hide
        Marco Pivetta added a comment -

        Benjamin Morel I think a pull request against the doctrine website (https://github.com/doctrine/doctrine-website-sphinx) would be fine...

        Show
        Marco Pivetta added a comment - Benjamin Morel I think a pull request against the doctrine website ( https://github.com/doctrine/doctrine-website-sphinx ) would be fine...
        Guilherme Blanco made changes -
        Issue Type Task [ 3 ] Documentation [ 6 ]
        Guilherme Blanco made changes -
        Fix Version/s 2.x [ 10090 ]
        Fix Version/s 2.0 [ 10021 ]
        Hide
        Steve Müller added a comment -

        This should go into https://github.com/doctrine/coding-standard repo (long term).

        Show
        Steve Müller added a comment - This should go into https://github.com/doctrine/coding-standard repo (long term).

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-585, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Jonathan H. Wage
            Reporter:
            Roman S. Borschel
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated: