Details

    • Type: Documentation
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.x
    • Component/s: None
    • Security Level: All
    • Labels:

      Description

      We need a new coding standards document for Doctrine 2.

        Issue Links

          Activity

          Hide
          ocramius Marco Pivetta added a comment -

          Please just refer to https://github.com/doctrine/coding-standard, which is already PSR-2 based (with variations and more strictness)

          Show
          ocramius Marco Pivetta added a comment - Please just refer to https://github.com/doctrine/coding-standard , which is already PSR-2 based (with variations and more strictness)
          Hide
          phansys Phansys added a comment -

          @ocramius, Is there a rule for spaces arround `!` operator? https://github.com/doctrine/doctrine2/pull/1133#discussion_r17459791

          Show
          phansys Phansys added a comment - @ocramius, Is there a rule for spaces arround `!` operator? https://github.com/doctrine/doctrine2/pull/1133#discussion_r17459791
          Hide
          phansys Phansys added a comment -

          I just found another set of rules inside https://github.com/doctrine/doctrine2/blob/14ff7f50cfea67d8a4dca37b8ca364d2a83b9864/CONTRIBUTING.md#coding-standard. Which is the current valid standard?

          Show
          phansys Phansys added a comment - I just found another set of rules inside https://github.com/doctrine/doctrine2/blob/14ff7f50cfea67d8a4dca37b8ca364d2a83b9864/CONTRIBUTING.md#coding-standard . Which is the current valid standard?
          Hide
          ocramius Marco Pivetta added a comment - - edited

          Phansys yes, that's doctrine specific (spaces around {{ ! }} )

          Show
          ocramius Marco Pivetta added a comment - - edited Phansys yes, that's doctrine specific (spaces around {{ ! }} )
          Show
          phansys Phansys added a comment - Perfect! https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1303 What about the disambiguation between the CS? https://github.com/doctrine/coding-standard/tree/master/Docs#doctrine-coding-standard vs https://github.com/doctrine/doctrine2/blob/14ff7f50cfea67d8a4dca37b8ca364d2a83b9864/CONTRIBUTING.md#coding-standard

            People

            • Assignee:
              jwage Jonathan H. Wage
              Reporter:
              romanb Roman S. Borschel
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: