Doctrine 2 - ORM

Remove unsigned/fixed

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0-ALPHA2
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

Changeset 6348 introduced unsigned/fixed properties for column metadata. Unsigned is completely unportable and fixed is unnecessary (we could simply introduce a fixed string type for this).

These 2 properties need to be removed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roman S. Borschel added a comment -

[Comment from guilhermeblanco:]

Ok, perfect!

We could easily drop it. But I'd also suggest that we simplify the SchemaManagers?, since it does a lot of weird things (looks like an imported piece of 1.X code) to return a better handled (and more useful) information for us.

Also... we should even consider moving that piece of code to ORM, since it's an ORM specific information (converts DBAL datatypes to ORM datatypes).

Show
Roman S. Borschel added a comment - [Comment from guilhermeblanco:] Ok, perfect! We could easily drop it. But I'd also suggest that we simplify the SchemaManagers?, since it does a lot of weird things (looks like an imported piece of 1.X code) to return a better handled (and more useful) information for us. Also... we should even consider moving that piece of code to ORM, since it's an ORM specific information (converts DBAL datatypes to ORM datatypes).
Hide
Permalink
Rémi SAUVAT added a comment -

Sorry to comment on an old bug but I have a problem. I understand why you want to remove the unsigned property and you proposed to remove the fixed property and implement a fixedstring type. But the problem is you removed the fixed property without implementing the new type so with Doctrine 2 it is not possible to create CHAR columns instead of VARCHAR which is different performance and storage wise in the database.

Show
Rémi SAUVAT added a comment - Sorry to comment on an old bug but I have a problem. I understand why you want to remove the unsigned property and you proposed to remove the fixed property and implement a fixedstring type. But the problem is you removed the fixed property without implementing the new type so with Doctrine 2 it is not possible to create CHAR columns instead of VARCHAR which is different performance and storage wise in the database.
Hide
Permalink
Benjamin Eberlei added a comment -

You can, use the columnDefinition http://www.doctrine-project.org/docs/orm/2.0/en/reference/annotations-reference.html#annref-column or just define your own type.

Show
Benjamin Eberlei added a comment - You can, use the columnDefinition http://www.doctrine-project.org/docs/orm/2.0/en/reference/annotations-reference.html#annref-column or just define your own type.

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Roman S. Borschel
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: