Doctrine 2 - ORM

Cached resultset do not add Entities in UnitOfWork

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.2
  • Component/s: None
  • Security Level: All
  • Labels:
    None

Description

When using resultset cache, when you fetch for these object and attempt to manipulate them, they fail to work giving this message:

Notice:  Undefined index: 000000006f95482300000000384dffac in /srv/app/library/Doctrine/ORM/UnitOfWork.php on line 1901

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. DDC-217 Result cache should cache the SQL result and not the final objects

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roman S. Borschel added a comment -

Objects coming from the result cache are all detached. The EM does not care about them unless you merge() them. But there should probably be a better exception instead of this notice. Please show the code that causes the notice.

PS: Result caching objects is inefficient.

Show
Roman S. Borschel added a comment - Objects coming from the result cache are all detached. The EM does not care about them unless you merge() them. But there should probably be a better exception instead of this notice. Please show the code that causes the notice. PS: Result caching objects is inefficient.
Roman S. Borschel made changes -
Field Original Value New Value
Issue Type Bug [ 1 ] Improvement [ 4 ]
Priority Critical [ 2 ] Major [ 3 ]
Roman S. Borschel made changes -
Link This issue relates to DDC-217 [ DDC-217 ]
Hide
Permalink
Guilherme Blanco added a comment -

Test case attached.

This is a situation where it should work smoothly IMHO.

Show
Guilherme Blanco added a comment - Test case attached. This is a situation where it should work smoothly IMHO.
Guilherme Blanco made changes -
Attachment DDC446Test.php [ 10508 ]
Hide
Permalink
Roman S. Borschel added a comment -

No, it should not work smoothly because $user is a detached object. It should throw an exception but the problem is that its hard to detect whether an object is detached in _doPersist.

Show
Roman S. Borschel added a comment - No, it should not work smoothly because $user is a detached object. It should throw an exception but the problem is that its hard to detect whether an object is detached in _doPersist.
Hide
Permalink
Roman S. Borschel added a comment -

You need to understand the difference between managed and detached. Its very important.

Show
Roman S. Borschel added a comment - You need to understand the difference between managed and detached. Its very important.
Hide
Permalink
Guilherme Blanco added a comment -

Adding merge doesn't work too.... same error.

Juyst add $this->_em->merge($user); in line 52.

Show
Guilherme Blanco added a comment - Adding merge doesn't work too.... same error. Juyst add $this->_em->merge($user); in line 52.
Hide
Permalink
Roman S. Borschel added a comment -

Of course it wouldnt because thats not how merge works. Merge returns a managed copy.

So you would do:

$managedUser = $this->_em->merge($user);

...

$article->setUser($managedUser);

...
Show
Roman S. Borschel added a comment - Of course it wouldnt because thats not how merge works. Merge returns a managed copy. So you would do: $managedUser = $ this ->_em->merge($user); ... $article->setUser($managedUser); ...
Hide
Permalink
Roman S. Borschel added a comment -

http://www.doctrine-project.org/documentation/manual/2_0/en/working-with-objects:merging-entities

Show
Roman S. Borschel added a comment - http://www.doctrine-project.org/documentation/manual/2_0/en/working-with-objects:merging-entities
Roman S. Borschel made changes -
Fix Version/s 2.1 [ 10022 ]
Benjamin Eberlei made changes -
Fix Version/s 2.x [ 10090 ]
Fix Version/s 2.1 [ 10022 ]
Hide
Permalink
Benjamin Eberlei added a comment -

Implemented through DDC-217

Show
Benjamin Eberlei added a comment - Implemented through DDC-217
Benjamin Eberlei made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.2-DEV [ 10157 ]
Fix Version/s 2.x [ 10090 ]
Resolution Fixed [ 1 ]
Benjamin Eberlei made changes -
Workflow jira [ 11096 ] jira-feedback [ 14339 ]
Benjamin Eberlei made changes -
Workflow jira-feedback [ 14339 ] jira-feedback2 [ 16203 ]
Benjamin Eberlei made changes -
Workflow jira-feedback2 [ 16203 ] jira-feedback3 [ 18456 ]
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-446, expand=changesets[-21:-1].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Guilherme Blanco
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: