Doctrine 2 - ORM

Problem when I make a INNER JOIN between 2 classes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0-ALPHA4
  • Fix Version/s: 2.0-BETA4
  • Component/s: None
  • Security Level: All
  • Labels:
    None
  • Environment:

Description

I hae some problems when I make a inner join between 2 classes, one of these classes makes join to others 2 classes in the same time and when I try to make a inner to this class, it's not coming like a object, but object Id...

I don't know why its happening..

I make a test case..there're all the classes and yml that show my problem..it's on ItemPregaoTest.php.. just need to run phpunit in this file..

  1. File
    DDC419Test.php
    20/Mar/10 10:37 AM
    2 kB
    Benjamin Eberlei
  2. File
    TestCase.tar.bz2
    12/Mar/10 2:38 PM
    609 kB
    Henrique Girardi dos Santos

Issue Links

depends on

Bug - A problem which impairs or prevents the functions of the product. DDC-522 Join columns can not be named the same as the association fields.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

This is what returns for me:

object(stdClass)[82]
  public '__CLASS__' => string 'ItemPregao' (length=10)
  public 'id' => int 1
  public 'item' => string '1' (length=1)

The expected result I guess. What happens for you?

Show
Benjamin Eberlei added a comment - This is what returns for me: object(stdClass)[82] public '__CLASS__' => string 'ItemPregao' (length=10) public 'id' => int 1 public 'item' => string '1' (length=1) The expected result I guess. What happens for you?
Hide
Permalink
Henrique Girardi dos Santos added a comment - - edited

Ok...this is what happen for me...
but I think the expected result would be

object(stdClass)[82]
  public '__CLASS__' => string 'ItemPregao' (length=10)
  public 'id' => int 1
  public 'item' => string 'Item' (length=4)

because 'public item' makes refereces to Item class, so I think it should give me a Item class, not its Id...

Show
Henrique Girardi dos Santos added a comment - - edited Ok...this is what happen for me... but I think the expected result would be object(stdClass)[82] public '__CLASS__' => string 'ItemPregao' (length=10) public 'id' => int 1 public 'item' => string 'Item' (length=4) because 'public item' makes refereces to Item class, so I think it should give me a Item class, not its Id...
Hide
Permalink
Henrique Girardi dos Santos added a comment -

When I try to make a inner join between Item and ItemPregao, happens what I've said before, but if I make a inner join between Item and its refereces tables, it's working fine

$qb = $this->em->createQueryBuilder();
        $qb->select('i, cc, ca, cl')
           ->from('Item', 'i')
           ->innerJoin('i.classificacaoCatalogo', 'cc')
           ->innerJoin('cc.catalogo', 'ca')
           ->innerJoin('cc.classificacao', 'cl')
        ;

object(stdClass)[141]
  public '__CLASS__' => string 'Item' (length=4)
  public 'id' => int 1
  public 'descricao' => string 'ITEM 1' (length=6)
  public 'classificacaoCatalogo' => 
    object(stdClass)[99]
      public '__CLASS__' => string 'ClassificacaoCatalogo' (length=21)
      public 'id' => int 1
      public 'classificacao' => string 'Classificacao' (length=13)
      public 'catalogo' => string 'Catalogo' (length=8)

It brings a class on 'classificacaoCatalogo' and inside classificacaoCatalogo you can see that 'classificacao' and 'catalogo' are objects too..so it worked! But If I make this:

$qb = $this->em->createQueryBuilder();
        $qb->select('ip, i')
           ->from('ItemPregao', 'ip')
           ->innerJoin('ip.item', 'i');

do not work like before..

object(stdClass)[152]
  public '__CLASS__' => string 'ItemPregao' (length=10)
  public 'id' => int 1
  public 'item' => int 1

'item' should be a object, not a integer..

Show
Henrique Girardi dos Santos added a comment - When I try to make a inner join between Item and ItemPregao, happens what I've said before, but if I make a inner join between Item and its refereces tables, it's working fine $qb = $ this ->em->createQueryBuilder(); $qb->select('i, cc, ca, cl') ->from('Item', 'i') ->innerJoin('i.classificacaoCatalogo', 'cc') ->innerJoin('cc.catalogo', 'ca') ->innerJoin('cc.classificacao', 'cl') ; object(stdClass)[141] public '__CLASS__' => string 'Item' (length=4) public 'id' => int 1 public 'descricao' => string 'ITEM 1' (length=6) public 'classificacaoCatalogo' => object(stdClass)[99] public '__CLASS__' => string 'ClassificacaoCatalogo' (length=21) public 'id' => int 1 public 'classificacao' => string 'Classificacao' (length=13) public 'catalogo' => string 'Catalogo' (length=8) It brings a class on 'classificacaoCatalogo' and inside classificacaoCatalogo you can see that 'classificacao' and 'catalogo' are objects too..so it worked! But If I make this: $qb = $ this ->em->createQueryBuilder(); $qb->select('ip, i') ->from('ItemPregao', 'ip') ->innerJoin('ip.item', 'i'); do not work like before.. object(stdClass)[152] public '__CLASS__' => string 'ItemPregao' (length=10) public 'id' => int 1 public 'item' => int 1 'item' should be a object, not a integer..
Hide
Permalink
Benjamin Eberlei added a comment -

Ah now I see it. Yes, this seems to be a problem.

Show
Benjamin Eberlei added a comment - Ah now I see it. Yes, this seems to be a problem.
Hide
Permalink
Benjamin Eberlei added a comment -

I have taken some time now trying to re-produce it, there is definately a bug i have identified, however i havent found the reason yet.

Show
Benjamin Eberlei added a comment - I have taken some time now trying to re-produce it, there is definately a bug i have identified, however i havent found the reason yet.
Hide
Permalink
Henrique Girardi dos Santos added a comment -

ok man!
I've try to find the reason too but I havent found yet too...
I dont know if there's something about the item are conected to a table that there're 2 table...
i dont know :S

Show
Henrique Girardi dos Santos added a comment - ok man! I've try to find the reason too but I havent found yet too... I dont know if there's something about the item are conected to a table that there're 2 table... i dont know :S
Hide
Permalink
Benjamin Eberlei added a comment -

I found the issue. A quick fix is to rename the join column to "item_id" instead of "item". This is causing the bug, we will look how to fix it.

@Roman:

This is particularly nasty, in UnitOfWork::createEntity the join column is set to the field name in $data, which makes the following code write the primitive FK value to the entity:

            if ($this->_useCExtension) {
                doctrine_populate_data($entity, $data);
            } else {
                foreach ($data as $field => $value) {
                    if (isset($class->reflFields[$field])) {
                        $class->reflFields[$field]->setValue($entity, $value);
                    }
                }
            }

This then leads in the ObjectHydrator to:

                    // PATH B: Single-valued association
                    $reflFieldValue = $reflField->getValue($parentObject);
                    if ( ! $reflFieldValue || isset($this->_hints[Query::HINT_REFRESH])) {

not evaluating to null, but to the primitive value. the If condition does not match here and the relation is never set.

A simple solution would be to replace !$reflFieldValue with !is_object().

Show
Benjamin Eberlei added a comment - I found the issue. A quick fix is to rename the join column to "item_id" instead of "item". This is causing the bug, we will look how to fix it. @Roman: This is particularly nasty, in UnitOfWork::createEntity the join column is set to the field name in $data, which makes the following code write the primitive FK value to the entity: if ($ this ->_useCExtension) { doctrine_populate_data($entity, $data); } else { foreach ($data as $field => $value) { if (isset($class->reflFields[$field])) { $class->reflFields[$field]->setValue($entity, $value); } } } This then leads in the ObjectHydrator to: // PATH B: Single-valued association $reflFieldValue = $reflField->getValue($parentObject); if ( ! $reflFieldValue || isset($ this ->_hints[Query::HINT_REFRESH])) { not evaluating to null, but to the primitive value. the If condition does not match here and the relation is never set. A simple solution would be to replace !$reflFieldValue with !is_object().
Hide
Permalink
Benjamin Eberlei added a comment -

Attached a reproduce test-case.

Show
Benjamin Eberlei added a comment - Attached a reproduce test-case.
Hide
Permalink
Roman S. Borschel added a comment -

I see. As their is an easy workaround, this is not a blocker, however.

Show
Roman S. Borschel added a comment - I see. As their is an easy workaround, this is not a blocker, however.
Hide
Permalink
Roman S. Borschel added a comment -

DDC-522 needs to be fixed, then this issue is solved, too (its the same after all, the other issue is just more specific).

Show
Roman S. Borschel added a comment - DDC-522 needs to be fixed, then this issue is solved, too (its the same after all, the other issue is just more specific).
Hide
Permalink
Roman S. Borschel added a comment -

Scheduled for beta2

Show
Roman S. Borschel added a comment - Scheduled for beta2
Hide
Permalink
Roman S. Borschel added a comment -

Should be fixed now in master.

Show
Roman S. Borschel added a comment - Should be fixed now in master.

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Henrique Girardi dos Santos
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: