Doctrine 2 - ORM

Introduce UnitOfWork Stages and throw exceptions for wrong method uses

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.0-ALPHA4
  • Fix Version/s: None
  • Component/s: ORM
  • Security Level: All
  • Labels:
    None

Description

Currently the event architecture is fragile when used wrong. I already see lots of "bug reports" popping up on this issue due to people dont understanding what is doable and what is not.

How about we introduce an instance variable stage into the UnitOfWork and introduce an assertIsInStages($stages) protected method which is called ineach major command method of the UnitOfWork to verify its applied correctly?

Stages could be:

UNFLUSHED
PRE_COMPUTE_CHANGESETS
POST_COMPUTE_CHANGESETS
FLUSH_LOOP
TRANSACTION_COMPLETED

Activity

Hide
Permalink
Roman S. Borschel added a comment - - edited

I'm not sure. I'm afraid this will just add code bloat with the only goal to provide better error messages and its fragile to do right. There will surely be places missed in the code where to check for the stage and it might even constrain some valid use-cases we dont think of yet.

So I'm afraid that this would hurt more than it would help.

Show
Roman S. Borschel added a comment - - edited I'm not sure. I'm afraid this will just add code bloat with the only goal to provide better error messages and its fragile to do right. There will surely be places missed in the code where to check for the stage and it might even constrain some valid use-cases we dont think of yet. So I'm afraid that this would hurt more than it would help.

People

  • Assignee:
    Roman S. Borschel
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: